Admixtures in BrowserTestBase

content/public/test/browser_test_base.cc

Index: content/public/test/browser_test_base.cc
diff --git a/content/public/test/browser_test_base.cc b/content/public/test/browser_test_base.cc
index 34932427aa6b832a7b00595fadf4f11e9c2509eb..0bc77f9ded28d523cae90d6e3eb78bc71537323d 100644
--- a/content/public/test/browser_test_base.cc
+++ b/content/public/test/browser_test_base.cc
@@ -12,8 +12,8 @@
 #include "base/strings/string_number_conversions.h"
 #include "base/sys_info.h"
 #include "base/test/test_timeouts.h"
-#include "content/public/app/content_main.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
+#include "content/public/app/content_main.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/main_function_params.h"
@@ -158,7 +158,6 @@ BrowserTestBase::~BrowserTestBase() {
 
 void BrowserTestBase::SetUp() {
   CommandLine* command_line = CommandLine::ForCurrentProcess();
-
   // Override the child process connection timeout since tests can exceed that
   // when sharded.
   command_line->AppendSwitchASCII(
@@ -238,6 +237,11 @@ void BrowserTestBase::SetUp() {
   net::ScopedDefaultHostResolverProc scoped_local_host_resolver_proc(
       rule_based_resolver_.get());
   SetUpInProcessBrowserTestFixture();
+  for (ScopedVector<Admixture>::iterator it = admixtures_.begin();

[dzhioev (left Google), 2014/08/18 12:11:46]

You call admixtures' SetUp* method after main test's SetUp* method here, but for
SetUpOnMainThread and SetUpCommandLine you do the opposite: first call test's
SetUp* then admixtures' SetUp*. Let's be consistent and choose one order of
calling SetUp*. I think the better one is first admixtures then test, because
test can use admixtures in its SetUp* somehow.

[Lisa Ignatyeva, 2014/08/18 12:20:41]

Done.

+       it != admixtures_.end();
+       ++it) {
+    (*it)->SetUpInProcessBrowserTestFixture();
+  }
 
   base::Closure* ui_task =
       new base::Closure(
@@ -304,4 +308,12 @@ bool BrowserTestBase::UsingOSMesa() const {
          gfx::kGLImplementationOSMesaName;
 }
 
+void BrowserTestBase::AddAdmixture(BrowserTestBase::Admixture* admixture) {
+  admixtures_.push_back(admixture);
+}
+
+std::vector<BrowserTestBase::Admixture*> BrowserTestBase::GetAdmixtures() {
+  return admixtures_.get();
+}
+
 }  // namespace content