Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 468443002: Cleanup namespace usage in platform/fonts/. (Closed)

Created:
6 years, 4 months ago by heeyoun.lee
Modified:
6 years, 4 months ago
Reviewers:
haraken, tkent, kangil_
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in platform/fonts/. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180224

Patch Set 1 #

Total comments: 6

Patch Set 2 : Cleanup namespace usage in platform/fonts/. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -47 lines) Patch
M Source/platform/fonts/Character.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Character.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/CustomFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FixedPitchFontType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCacheKey.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCacheTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/fonts/FontDataCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontDataCache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontFallbackList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontFallbackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontFamily.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontFamily.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontFeatureSettings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontFeatureSettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformFeatures.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontRenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GenericFontFamilySettings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GenericFontFamilySettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GlyphBuffer.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/fonts/GlyphPageTreeNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Latin1TextIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/SVGGlyph.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/WidthIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/WidthIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzFace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/linux/FontCacheLinux.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/fonts/linux/FontPlatformDataLinux.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/fonts/mac/FontCustomPlatformDataMac.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/opentype/OpenTypeUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
heeyoun.lee
6 years, 4 months ago (2014-08-12 12:22:59 UTC) #1
kangil_
Some changes in this CL added comments to show that this is end block of ...
6 years, 4 months ago (2014-08-13 01:33:10 UTC) #2
haraken
LGTM
6 years, 4 months ago (2014-08-13 01:35:20 UTC) #3
heeyoun.lee
https://codereview.chromium.org/468443002/diff/1/Source/platform/fonts/FontCache.cpp File Source/platform/fonts/FontCache.cpp (left): https://codereview.chromium.org/468443002/diff/1/Source/platform/fonts/FontCache.cpp#oldcode53 Source/platform/fonts/FontCache.cpp:53: using namespace WTF; On 2014/08/13 01:33:10, kangil_ wrote: > ...
6 years, 4 months ago (2014-08-13 02:57:27 UTC) #4
heeyoun.lee
The CQ bit was checked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-13 04:41:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/468443002/20001
6 years, 4 months ago (2014-08-13 04:42:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-13 05:44:08 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 05:47:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12656)
6 years, 4 months ago (2014-08-13 05:47:16 UTC) #9
heeyoun.lee
PTAL
6 years, 4 months ago (2014-08-13 06:13:22 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 00:42:32 UTC) #11
tkent
lgtm
6 years, 4 months ago (2014-08-14 00:42:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/468443002/20001
6 years, 4 months ago (2014-08-14 00:43:19 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 03:14:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180224

Powered by Google App Engine
This is Rietveld 408576698