Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: pkg/pkg.status

Issue 46843003: Wrap Directory.watch on linux for the watcher package. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/pkg.status
diff --git a/pkg/pkg.status b/pkg/pkg.status
index 529174485f6a7e957924af94561e2f7d9154293d..b3ef6ed9e2ec84f333ffbc5f09e0a685330b31db 100644
--- a/pkg/pkg.status
+++ b/pkg/pkg.status
@@ -245,7 +245,6 @@ unittest/test/*_minified_test: Skip # DO NOT COPY THIS UNLESS YOU WORK ON DART2J
[ $arch == simarm || $arch == simmips ]
barback/test/too_many_open_files_test: Pass, Slow, Fail # 14220
third_party/html5lib/test/tokenizer_test: Pass, Slow
-watcher/test/no_subscription_test: Pass, Fail # Issue 13705.
# Skip serialization test that explicitly has no library declaration in the
# test on Dartium, which requires all tests to have a library.
@@ -379,6 +378,10 @@ scheduled_test/test/scheduled_test/wrap_async_test: StaticWarning
scheduled_test/test/scheduled_test/wrap_future_test: StaticWarning
unittest/test/matchers_test: StaticWarning
unittest/test/mock_test: StaticWarning
-watcher/test/directory_watcher_test: StaticWarning
-watcher/test/no_subscription_test: StaticWarning
-watcher/test/ready_test: StaticWarning
+watcher/test/*: StaticWarning
Bob Nystrom 2013/11/06 19:24:04 What's this for? Can it be fixed?
nweiz 2013/11/07 00:46:37 This is the same warning that was there before. I'
+
+[ $runtime == vm && ($system == windows || $system == macos) ]
+watcher/test/*/linux_test: Skip
+
+[ $runtime == vm && $system == linux ]
+watcher/test/*/linux_test: Pass, Slow # Issue 14606
Bob Nystrom 2013/11/06 19:24:04 Before only no_subscription_test was flaky. Now al
nweiz 2013/11/07 00:46:37 This isn't a flaky annotation, it's a slow annotat
« no previous file with comments | « no previous file | pkg/watcher/lib/src/directory_watcher.dart » ('j') | pkg/watcher/lib/src/directory_watcher.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698