pkg/watcher/lib/watcher.dart - Issue 46843003: Wrap Directory.watch on linux for the watcher package.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/watcher/lib/watcher.dart

Issue 46843003: Wrap Directory.watch on linux for the watcher package. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library watcher;	5 library watcher;

6	6

7 export 'src/watch_event.dart';	7 export 'src/watch_event.dart';

8 export 'src/directory_watcher.dart';	8 export 'src/directory_watcher.dart';

	9 export 'src/directory_watcher/polling.dart';
	Bob Nystrom 2013/11/06 19:24:04 I don't think we should export this. I don't think we should export this. nweiz 2013/11/07 00:46:37 I think we should allow users to explicitly use th Show quoted text On 2013/11/06 19:24:04, Bob Nystrom wrote: > I don't think we should export this. I think we should allow users to explicitly use the polling watcher if they want. Native watchers are always going to involve some behavioral compromises that users may not want to buy into. Bob Nystrom 2013/11/07 18:16:05 That makes sense. Show quoted text On 2013/11/07 00:46:37, nweiz wrote: > On 2013/11/06 19:24:04, Bob Nystrom wrote: > > I don't think we should export this. > > I think we should allow users to explicitly use the polling watcher if they > want. Native watchers are always going to involve some behavioral compromises > that users may not want to buy into. That makes sense.
OLD	NEW