app_shell: Shut down in response to power button.

ui/compositor/test/in_process_context_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/test/in_process_context_factory.h"
 
 #include "base/command_line.h"
 #include "base/threading/thread.h"
 #include "cc/output/output_surface.h"
 #include "cc/test/test_shared_bitmap_manager.h"
 #include "ui/compositor/compositor_switches.h"
 #include "ui/compositor/reflector.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_surface.h"
 #include "webkit/common/gpu/context_provider_in_process.h"
 #include "webkit/common/gpu/grcontext_for_webgraphicscontext3d.h"
 #include "webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h"
 
 namespace ui {
 
 InProcessContextFactory::InProcessContextFactory()
     : shared_bitmap_manager_(new cc::TestSharedBitmapManager()) {
+#if defined(UNIT_TEST)

[James Cook, 2014/08/23 00:55:00]

I'm not sure this works. In particular, I think only *_unittest.cc files (and
maybe some test support files?) are compiled with this flag. Otherwise the
entire project would have to be rebuilt to build the unit_tests binary.

"git grep UNIT_TEST" shows it only used in headers, which could be compiled
differently for the unit test binary due to inlining.

[Daniel Erat, 2014/08/23 02:21:31]

what you write makes sense. it worked when i tested it, but probably i just
happened to build the test first. i've changed this back to a DCHECK and tweaked
the message.

+  CHECK_NE(gfx::GetGLImplementation(), gfx::kGLImplementationNone)
+      << "Ensure that the test binary's main() is calling "
+      << "gfx::GLSurface::InitializeOneOffForTests()";
+#else
   DCHECK_NE(gfx::GetGLImplementation(), gfx::kGLImplementationNone);
+#endif
+
 #if defined(OS_CHROMEOS)
   bool use_thread = !CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kUIDisableThreadedCompositing);
 #else
   bool use_thread = false;
 #endif
   if (use_thread) {
     compositor_thread_.reset(new base::Thread("Browser Compositor"));
     compositor_thread_->Start();
   }
@@ skipping 59 matching lines @@
   return shared_bitmap_manager_.get();
 }
 
 base::MessageLoopProxy* InProcessContextFactory::GetCompositorMessageLoop() {
   if (!compositor_thread_)
     return NULL;
   return compositor_thread_->message_loop_proxy();
 }
 
 }  // namespace ui