app_shell: Shut down in response to power button.

extensions/shell/browser/shell_desktop_controller_unittest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/shell/browser/shell_desktop_controller.h"
+
+#include "base/macros.h"

[James Cook, 2014/08/23 00:55:00]

Nice IWYU

+#include "base/memory/scoped_ptr.h"
+#include "base/time/time.h"
+#include "ui/aura/test/aura_test_base.h"
+
+#if defined(OS_CHROMEOS)
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_dbus_thread_manager.h"
+#include "chromeos/dbus/fake_power_manager_client.h"
+#endif
+
+namespace extensions {
+
+class ShellDesktopControllerTest : public aura::test::AuraTestBase {
+ public:
+  ShellDesktopControllerTest()
+#if defined(OS_CHROMEOS)
+      : power_manager_client_(NULL)
+#endif
+      {
+  }
+  virtual ~ShellDesktopControllerTest() {}
+
+  virtual void SetUp() OVERRIDE {
+#if defined(OS_CHROMEOS)
+    chromeos::FakeDBusThreadManager* manager =
+        new chromeos::FakeDBusThreadManager();
+    power_manager_client_ = new chromeos::FakePowerManagerClient();
+    manager->SetPowerManagerClient(make_scoped_ptr(power_manager_client_).
+        PassAs<chromeos::PowerManagerClient>());
+    chromeos::DBusThreadManager::InitializeForTesting(manager);
+#endif
+    aura::test::AuraTestBase::SetUp();
+    controller_.reset(new ShellDesktopController());
+  }
+
+  virtual void TearDown() OVERRIDE {
+    controller_.reset();
+    aura::test::AuraTestBase::TearDown();
+#if defined(OS_CHROMEOS)
+    chromeos::DBusThreadManager::Shutdown();
+#endif
+  }
+
+ protected:
+  scoped_ptr<ShellDesktopController> controller_;
+
+#if defined(OS_CHROMEOS)
+  chromeos::FakePowerManagerClient* power_manager_client_;  // Weak pointer.

[James Cook, 2014/08/23 00:55:00]

nit: "Weak pointer" -> "Not owned", because we have a real WeakPtr class and
this isn't one.

[Daniel Erat, 2014/08/23 02:21:31]

i can never remember if you're the reviewer who tells me to use "Weak pointer"
or the one who tells me to use "Not owned". now i know :-P

+#endif
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ShellDesktopControllerTest);
+};
+
+#if defined(OS_CHROMEOS)
+TEST_F(ShellDesktopControllerTest, PowerButton) {

[James Cook, 2014/08/23 00:55:00]

nit: Comment above the test about what it intends to test.

[Daniel Erat, 2014/08/23 02:21:31]

Done.

+  // Ignore button releases.
+  power_manager_client_->SendPowerButtonEvent(false /* down */,
+                                              base::TimeTicks());
+  EXPECT_EQ(0, power_manager_client_->num_request_shutdown_calls());
+
+  // A button press should trigger a shutdown request.
+  power_manager_client_->SendPowerButtonEvent(true /* down */,
+                                              base::TimeTicks());
+  EXPECT_EQ(1, power_manager_client_->num_request_shutdown_calls());
+}
+#endif
+
+}  // namespace extensions