Add the addIceCandidate failure case to webrtc-internals.

content/renderer/media/peer_connection_tracker.cc

Index: content/renderer/media/peer_connection_tracker.cc
diff --git a/content/renderer/media/peer_connection_tracker.cc b/content/renderer/media/peer_connection_tracker.cc
index 5aac78c3fd50bceb41dfbdc590b656b7862295d2..57d0a45184ccf61f6c6449b3a5da5cca7e868698 100644
--- a/content/renderer/media/peer_connection_tracker.cc
+++ b/content/renderer/media/peer_connection_tracker.cc
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 #include "content/renderer/media/peer_connection_tracker.h"
 
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/common/media/peer_connection_tracker_messages.h"
 #include "content/renderer/media/rtc_media_constraints.h"
@@ -390,12 +391,20 @@ void PeerConnectionTracker::TrackUpdateIce(
 void PeerConnectionTracker::TrackAddIceCandidate(
       RTCPeerConnectionHandler* pc_handler,
       const blink::WebRTCICECandidate& candidate,
-      Source source) {
-  string value = "mid: " + base::UTF16ToUTF8(candidate.sdpMid()) + ", " +
-                 "candidate: " + base::UTF16ToUTF8(candidate.candidate());
-  SendPeerConnectionUpdate(
-      pc_handler,
-      source == SOURCE_LOCAL ? "onIceCandidate" : "addIceCandidate", value);
+      Source source,
+      bool succeeded) {
+  string value =
+      "sdpMid: " + base::UTF16ToUTF8(candidate.sdpMid()) + ", " +
+      "sdpMLineIndex: " + base::IntToString(candidate.sdpMLineIndex()) + ", " +
+      "candidate: " + base::UTF16ToUTF8(candidate.candidate());
+
+  // OnIceCandidate always succeeds as it's a callback from the browser.
+  string event =
+      (source == SOURCE_LOCAL) ? "onIceCandidate"

[tommi (sloooow) - chröme, 2014/09/05 07:25:23]

can we add a DCHECK(source != SOURCE_LOCAL || succeeded) to make sure that
succeeded is always true for SOURCE_LOCAL (as it seems from this check).

+                               : (succeeded ? "addIceCandidate"
+                                            : "addIceCandidateFailed");
+
+  SendPeerConnectionUpdate(pc_handler, event, value);
 }
 
 void PeerConnectionTracker::TrackAddStream(