Add the addIceCandidate failure case to webrtc-internals.

content/renderer/media/rtc_peer_connection_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/rtc_peer_connection_handler.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 622 matching lines @@
   return true;
 }
 
 bool RTCPeerConnectionHandler::addICECandidate(
     const blink::WebRTCICECandidate& candidate) {
   scoped_ptr<webrtc::IceCandidateInterface> native_candidate(
       dependency_factory_->CreateIceCandidate(
           base::UTF16ToUTF8(candidate.sdpMid()),
           candidate.sdpMLineIndex(),
           base::UTF16ToUTF8(candidate.candidate())));
-  if (!native_candidate) {
+  bool return_value = false;
+
+  if (native_candidate) {
+    return_value =
+        native_peer_connection_->AddIceCandidate(native_candidate.get());
+    LOG_IF(ERROR, !return_value) << "Error processing ICE candidate.";
+  } else {
     LOG(ERROR) << "Could not create native ICE candidate.";
-    return false;
   }
 
-  bool return_value =
-      native_peer_connection_->AddIceCandidate(native_candidate.get());
-  LOG_IF(ERROR, !return_value) << "Error processing ICE candidate.";
-
-  if (peer_connection_tracker_)
+  if (peer_connection_tracker_) {
     peer_connection_tracker_->TrackAddIceCandidate(
-        this, candidate, PeerConnectionTracker::SOURCE_REMOTE);
-
+        this, candidate, PeerConnectionTracker::SOURCE_REMOTE, return_value);
+  }
   return return_value;
 }
 
 void RTCPeerConnectionHandler::OnaddICECandidateResult(
     const blink::WebRTCVoidRequest& webkit_request, bool result) {
   if (!result) {
     // We don't have the actual error code from the libjingle, so for now
     // using a generic error string.
     return webkit_request.requestFailed(
         base::UTF8ToUTF16("Error processing ICE candidate"));
@@ skipping 289 matching lines @@
   if (!candidate->ToString(&sdp)) {
     NOTREACHED() << "OnIceCandidate: Could not get SDP string.";
     return;
   }
   blink::WebRTCICECandidate web_candidate;
   web_candidate.initialize(base::UTF8ToUTF16(sdp),
                            base::UTF8ToUTF16(candidate->sdp_mid()),
                            candidate->sdp_mline_index());
   if (peer_connection_tracker_)
     peer_connection_tracker_->TrackAddIceCandidate(
-        this, web_candidate, PeerConnectionTracker::SOURCE_LOCAL);
+        this, web_candidate, PeerConnectionTracker::SOURCE_LOCAL, true);
 
   client_->didGenerateICECandidate(web_candidate);
 }
 
 void RTCPeerConnectionHandler::OnDataChannel(
     webrtc::DataChannelInterface* data_channel) {
   if (peer_connection_tracker_)
     peer_connection_tracker_->TrackCreateDataChannel(
         this, data_channel, PeerConnectionTracker::SOURCE_REMOTE);
 
@@ skipping 21 matching lines @@
   webrtc::SessionDescriptionInterface* native_desc =
       dependency_factory_->CreateSessionDescription(type, sdp, error);
 
   LOG_IF(ERROR, !native_desc) << "Failed to create native session description."
                               << " Type: " << type << " SDP: " << sdp;
 
   return native_desc;
 }
 
 }  // namespace content