Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 468303003: Return string literals as const wchar_t*. (Closed)

Created:
6 years, 4 months ago by erikwright (departed)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Nico
Project:
chromium
Visibility:
Public.

Description

Return string literals as const wchar_t*. BUG=394842 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/terminate_on_heap_corruption_experiment_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
erikwright (departed)
jochen/thakis: PTAL. Fixes clang error reported by thakis.
6 years, 4 months ago (2014-08-13 18:33:32 UTC) #1
Nico
lgtm, thanks!
6 years, 4 months ago (2014-08-13 18:34:09 UTC) #2
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 4 months ago (2014-08-13 18:47:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/468303003/1
6 years, 4 months ago (2014-08-13 18:49:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 07:13:16 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 11:01:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289518

Powered by Google App Engine
This is Rietveld 408576698