Adding local stream mute tests, tightening up WebRTC audio tests.

Adding local stream mute tests, tightening up WebRTC audio tests.

These tests were originally made to cover http://crbug.com/398157.
Alas, that bug turned out to be very difficult to test since it does
not affect energy levels. That's what we use as a lightweight way to
detect whether audio is playing, but the bug managed to make audio stop
playing without affecting the levels. Still, I think the tests are
useful.

BUG=402860
R=perkj@chromium.org

Committed: https://crrev.com/08965ad892f1536513da21601983ddd57d2584bf
Cr-Commit-Position: refs/heads/master@{#291692}

[perkj_chrome, 2014-08-14 08:53:42]

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:354:
remoteStream.getVideoTracks()[0].enabled = enabled;
nit add assert that stream 0 and video track 0 exist, here and below.

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:376: reportTestSuccess();
Why reportTextSuccess? Why not add addExpectedEvent and event occured?

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:387: ensureSilence();
ie - change ensureSilence and call setAllEventsOccuredHAndler as you do in
callAndEnsureLocalVideoMutingDoesntMuteAudio

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:425:
callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
The problem we had is that the media player expect a video frame. To test that
you will have to disable local video before you send the video track on a pc.

[phoglund_chromium, 2014-08-14 09:17:38]

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:425:
callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
On 2014/08/14 08:53:42, perkj_ooo_until_25_of_August wrote:
> The problem we had is that the media player expect a video frame. To test that
> you will have to disable local video before you send the video track on a pc.
Yes. I tried that, and it repros, but the problem is that we can't seem to
detect it. I'm getting audio energy level readings on peer connection 2 that
look like the fake device signal, but I can't hear any audio. Since we're using
the former to detect audio we can't write a test to verify this.

[phoglund_chromium, 2014-08-14 09:20:45]

On 2014/08/14 09:17:38, phoglund wrote:
>
https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
> File content/test/data/media/peerconnection-call.html (right):
> 
>
https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
> content/test/data/media/peerconnection-call.html:425:
> callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
> On 2014/08/14 08:53:42, perkj_ooo_until_25_of_August wrote:
> > The problem we had is that the media player expect a video frame. To test
that
> > you will have to disable local video before you send the video track on a
pc.
> Yes. I tried that, and it repros, but the problem is that we can't seem to
> detect it. I'm getting audio energy level readings on peer connection 2 that
> look like the fake device signal, but I can't hear any audio. Since we're
using
> the former to detect audio we can't write a test to verify this.

This is what I tried (i.e. disable video right after gUM but before adding to
the peer connection):

diff --git a/content/test/data/media/peerconnection-call.html
b/content/test/data/media/peerconnection-call.html
index dc2e53e..3919f64 100644
--- a/content/test/data/media/peerconnection-call.html
+++ b/content/test/data/media/peerconnection-call.html
@@ -422,12 +422,32 @@
   }
 
   function callAndEnsureLocalVideoMutingDoesntMuteAudio(beLenient) {
-    callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
-    setAllEventsOccuredHandler(function() {
-      setAllEventsOccuredHandler(reportTestSuccess);
-      enableLocalVideo(gFirstConnection, false);
+    createConnections(null);
+
+    // Add the local stream to gFirstConnection to play one-way audio.
+    navigator.webkitGetUserMedia({audio: true, video: true},
+      addVideoDisabledStreamToTheFirstConnectionAndNegotiate,
+      printGetUserMediaError);
+
+    var onCallEstablished = function() {
       ensureAudioPlaying(beLenient);
+    };
+    setAllEventsOccuredHandler(function() {
+      console.log("!!!!");
+      assertEquals(gLocalStream.getAudioTracks()[0].enabled, true);
+     
assertEquals(gSecondConnection.getRemoteStreams()[0].getAudioTracks()[0].enabled,
true);
+     
assertEquals(gFirstConnection.getLocalStreams()[0].getAudioTracks()[0].enabled,
true);
+      reportTestSuccess();
     });
+
+    waitForConnectionToStabilize(gFirstConnection, onCallEstablished);
+
+//    callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
+//    setAllEventsOccuredHandler(function() {
+//      setAllEventsOccuredHandler(reportTestSuccess);
+//      enableLocalVideo(gFirstConnection, false);
+//      ensureAudioPlaying(beLenient);
+//    });
   }
 
   function callAndEnsureRemoteVideoMutingDoesntMuteAudio(beLenient) {
@@ -714,6 +734,13 @@
     negotiate();
   }
 
+  function addVideoDisabledStreamToTheFirstConnectionAndNegotiate(localStream)
{
+    displayAndRemember(localStream);
+    localStream.getVideoTracks()[0].enabled = false;
+    gFirstConnection.addStream(localStream);
+    negotiate();
+  }
+
   function verifyHasOneAudioAndVideoTrack(stream) {
     assertEquals(1, stream.getAudioTracks().length);
     assertEquals(1, stream.getVideoTracks().length);

[phoglund_chromium, 2014-08-19 09:02:16]

ping

[phoglund_chromium, 2014-08-25 09:41:46]

PTAL

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:354:
remoteStream.getVideoTracks()[0].enabled = enabled;
On 2014/08/14 08:53:41, perkj wrote:
> nit add assert that stream 0 and video track 0 exist, here and below.
I think that will be a lot of code that doesn't make the error reports better; I
think it'll be just as easy to understand the no such element errors that js
throws by default.

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:376: reportTestSuccess();
On 2014/08/14 08:53:41, perkj wrote:
> Why reportTextSuccess? Why not add addExpectedEvent and event occured?

Done.

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:387: ensureSilence();
On 2014/08/14 08:53:42, perkj wrote:
> ie - change ensureSilence and call setAllEventsOccuredHAndler as you do in
> callAndEnsureLocalVideoMutingDoesntMuteAudio

Done.

[perkj_chrome, 2014-08-25 12:05:47]

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/468243003/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:354:
remoteStream.getVideoTracks()[0].enabled = enabled;
On 2014/08/25 09:41:45, phoglund wrote:
> On 2014/08/14 08:53:41, perkj wrote:
> > nit add assert that stream 0 and video track 0 exist, here and below.
> I think that will be a lot of code that doesn't make the error reports better;
I
> think it'll be just as easy to understand the no such element errors that js
> throws by default.

Acknowledged.

https://codereview.chromium.org/468243003/diff/40001/content/browser/media/we...
File content/browser/media/webrtc_browsertest.cc (right):

https://codereview.chromium.org/468243003/diff/40001/content/browser/media/we...
content/browser/media/webrtc_browsertest.cc:360:
EstablishAudioVideoCallAndVerifyRemoteMutingWorks) {
I am afraid you will have to supress these tests on the dr memory bots too....

https://codereview.chromium.org/468243003/diff/40001/content/test/data/media/...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/468243003/diff/40001/content/test/data/media/...
content/test/data/media/peerconnection-call.html:372: function ensureSilence() {
Should this be moved to the utility.js?

https://codereview.chromium.org/468243003/diff/40001/content/test/data/media/...
content/test/data/media/peerconnection-call.html:383:
callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
Is there a risk that callAndEnsureAudioIsPlaying call reportTestSuccess before
line 385?

[phoglund_chromium, 2014-08-25 14:25:32]

https://codereview.chromium.org/468243003/diff/40001/content/browser/media/we...
File content/browser/media/webrtc_browsertest.cc (right):

https://codereview.chromium.org/468243003/diff/40001/content/browser/media/we...
content/browser/media/webrtc_browsertest.cc:360:
EstablishAudioVideoCallAndVerifyRemoteMutingWorks) {
On 2014/08/25 12:05:47, perkj wrote:
> I am afraid you will have to supress these tests on the dr memory bots too....
Well, let's see. I didn't see any of the muting tests in those suppressions.

https://codereview.chromium.org/468243003/diff/40001/content/test/data/media/...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/468243003/diff/40001/content/test/data/media/...
content/test/data/media/peerconnection-call.html:372: function ensureSilence() {
On 2014/08/25 12:05:47, perkj wrote:
> Should this be moved to the utility.js? 

Done. Moved some other stuff as well and raised the abstraction level so that
methods don't call gatherAudioLevelSamples directly.

https://codereview.chromium.org/468243003/diff/40001/content/test/data/media/...
content/test/data/media/peerconnection-call.html:383:
callAndEnsureAudioIsPlaying(beLenient, {audio: true, video: true});
On 2014/08/25 12:05:47, perkj wrote:
> Is there a risk that callAndEnsureAudioIsPlaying call reportTestSuccess before
> line 385? 
You mean line 384? No, callAndEnsure is async so it is guaranteed to execute 384
before any of the async stuff. So it can't finish before 384 changes the
handler.

[perkj_chrome, 2014-08-25 14:34:08]

lgtm

[phoglund_chromium, 2014-08-25 14:35:54]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-08-25 14:36:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/phoglund@chromium.org/468243003/80001

[commit-bot: I haz the power, 2014-08-25 15:43:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-25 16:22:18]

Committed patchset #5 (80001) as f855096be12b9e4f8268b0d37bf8a25c9149bedf

[commit-bot: I haz the power, 2014-09-10 02:34:52]

Patchset 5 (id:??) landed as
https://crrev.com/08965ad892f1536513da21601983ddd57d2584bf
Cr-Commit-Position: refs/heads/master@{#291692}