Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 468233004: Cleanup: Another round of removing unneeded grit #includes in chrome. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews, asanka, skanuj+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, zea+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, estade+watch_chromium.org, aboxhall+watch_chromium.org, Ilya Sherman, dyu1, dominich, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, Dane Wallinga, dbeam+watch-options_chromium.org, dtseng+watch_chromium.org, haitaol+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, kalyank, gcasto+watchlist_chromium.org, Jered, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, plundblad+watch_chromium.org, tfarina, donnd+watch_chromium.org, mcasas+watch_chromium.org, benquan, eroman, David Black, ben+ash_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, wjia+watch_chromium.org, mmenke, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Another round of removing unneeded grit #includes in chrome. This time, figure out what IDS entries are in a .grd file + .grdp files. Then look for files that have the associated #include, but does not use any of those entries. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290111

Patch Set 1 #

Patch Set 2 : revert 1 false positive, and rebase #

Patch Set 3 : rebase #

Patch Set 4 : fix mac, undo ui_localizer.mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/media_stream_capture_indicator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/contextual_search_promo_source_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/tab_contents_information.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_main_container.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_show_all_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/profile_error_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/bundle_installed_bubble.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/domain_reliability_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/gesture_config_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_utils_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/media/webrtc_logs_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/proxy_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
Lei Zhang
Remove used ones -> less #includes to convert later.
6 years, 4 months ago (2014-08-15 03:40:53 UTC) #1
tfarina
me -> thakis (as I have little time to give this a real review). It ...
6 years, 4 months ago (2014-08-15 03:48:47 UTC) #2
Lei Zhang
On 2014/08/15 03:48:47, tfarina wrote: > me -> thakis (as I have little time to ...
6 years, 4 months ago (2014-08-15 03:55:48 UTC) #3
Nico
lgtm!
6 years, 4 months ago (2014-08-15 03:58:44 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-15 04:32:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/468233004/20001
6 years, 4 months ago (2014-08-15 04:35:01 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-15 07:25:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 07:40:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/3550)
6 years, 4 months ago (2014-08-15 07:40:17 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-15 19:16:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/468233004/60001
6 years, 4 months ago (2014-08-15 19:18:26 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 00:32:06 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 01:40:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6363)
6 years, 4 months ago (2014-08-16 01:40:03 UTC) #14
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-16 02:05:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/468233004/60001
6 years, 4 months ago (2014-08-16 02:06:34 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 03:37:27 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 04:40:29 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6410)
6 years, 4 months ago (2014-08-16 04:40:32 UTC) #19
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-16 05:15:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/468233004/60001
6 years, 4 months ago (2014-08-16 05:16:56 UTC) #21
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 07:37:31 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (60001) as 290111

Powered by Google App Engine
This is Rietveld 408576698