Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 468223004: Chromecast: disables application cache. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, damienv1
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: disables application cache. Chromecast application cache is disabled due to storage constraints on device flash. Aside: removes "enable-webrtc-hw-decoding", which doesn't exist, and "enable-threaded-compositing", which is now enabled by default. R=lcwu@chromium.org,damienv@chromium.org BUG=336640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290022

Patch Set 1 #

Total comments: 2

Patch Set 2 : removes kEnableThreadedCompositing #

Patch Set 3 : rebase #

Patch Set 4 : actual rebase (git was within a couple minutes behind) :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chromecast/shell/browser/cast_browser_main_parts.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
gunsch
6 years, 4 months ago (2014-08-14 20:13:41 UTC) #1
lcwu1
https://codereview.chromium.org/468223004/diff/1/chromecast/shell/browser/cast_browser_main_parts.cc File chromecast/shell/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/468223004/diff/1/chromecast/shell/browser/cast_browser_main_parts.cc#newcode28 chromecast/shell/browser/cast_browser_main_parts.cc:28: { switches::kEnableThreadedCompositing, "" }, This flag is no longer ...
6 years, 4 months ago (2014-08-14 20:39:50 UTC) #2
gunsch
https://codereview.chromium.org/468223004/diff/1/chromecast/shell/browser/cast_browser_main_parts.cc File chromecast/shell/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/468223004/diff/1/chromecast/shell/browser/cast_browser_main_parts.cc#newcode28 chromecast/shell/browser/cast_browser_main_parts.cc:28: { switches::kEnableThreadedCompositing, "" }, On 2014/08/14 20:39:50, lcwu1 wrote: ...
6 years, 4 months ago (2014-08-14 20:44:59 UTC) #3
lcwu1
lgtm
6 years, 4 months ago (2014-08-15 00:23:20 UTC) #4
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-15 16:58:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/468223004/40001
6 years, 4 months ago (2014-08-15 16:59:43 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 17:54:30 UTC) #7
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-15 18:04:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/468223004/60001
6 years, 4 months ago (2014-08-15 18:08:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 19:59:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 20:24:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6182)
6 years, 4 months ago (2014-08-15 20:24:32 UTC) #12
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-15 20:28:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/468223004/60001
6 years, 4 months ago (2014-08-15 20:31:23 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:49:32 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (60001) as 290022

Powered by Google App Engine
This is Rietveld 408576698