Issue 468223002: Revert 289154 "Revert 289067 "Use RE string pattern matching for..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468223002: Revert 289154 "Revert 289067 "Use RE string pattern matching for..." (Closed)

Created:
6 years, 4 months ago by oshima

Modified:
6 years, 4 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 289154 "Revert 289067 "Use RE string pattern matching for..." > Revert 289067 "Use RE string pattern matching for blacklist stri..." > > Reason for revert: uninitialize memory access > > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/29469/steps/memory%20test%3A%20content/logs/stdio > > > Use RE string pattern matching for blacklist strings. > > > > Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor, > > and machine_model_name. > > > > BUG=396578 > > TBR=piman@chromium.org > > TEST=gpu_unittests > > > > Review URL: https://codereview.chromium.org/452293002 > > TBR=zmo@chromium.org > > Review URL: https://codereview.chromium.org/465163002 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289308

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+299 lines, -563 lines)			Patch
M	trunk/src/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	trunk/src/gpu/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/gpu/config/gpu_control_list.h	View	4 chunks	+10 lines, -41 lines	0 comments	Download
M	trunk/src/gpu/config/gpu_control_list.cc	View	14 chunks	+44 lines, -103 lines	0 comments	Download
M	trunk/src/gpu/config/gpu_control_list_entry_unittest.cc	View	9 chunks	+166 lines, -34 lines	0 comments	Download
M	trunk/src/gpu/config/gpu_control_list_format.txt	View	3 chunks	+9 lines, -11 lines	0 comments	Download
D	trunk/src/gpu/config/gpu_control_list_string_info_unittest.cc	View	1 chunk	+0 lines, -98 lines	0 comments	Download
M	trunk/src/gpu/config/gpu_control_list_unittest.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/gpu/config/gpu_driver_bug_list_json.cc	View	33 chunks	+38 lines, -149 lines	0 comments	Download
M	trunk/src/gpu/config/software_rendering_list_json.cc	View	20 chunks	+29 lines, -113 lines	0 comments	Download
M	trunk/src/gpu/gpu.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r289308.