Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4682002: Remove "name" field from indexed databases. (Closed)

Created:
10 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Bernhard Bauer, jorlow
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Remove "name" field from indexed databases. BUG=56248 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -423 lines) Patch
M chrome/app/nibs/CookieDetailsView.xib View 12 chunks +137 lines, -240 lines 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.h View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper_unittest.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/cocoa/cookie_details.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/cookie_details.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/cookie_details_unittest.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/options/cookies_view_handler.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/gtk/gtk_chrome_cookie_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/gtk_chrome_cookie_view.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/gtk/options/cookies_view_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_browsertest.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_context.h View 2 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_context.cc View 2 chunks +3 lines, -36 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/mock_browsing_data_indexed_db_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/cookies_view.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/cookies_view.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_specific_content_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_specific_content_settings.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/views/indexed_db_info_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/indexed_db_info_view.cc View 7 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
please review
10 years, 1 month ago (2010-11-08 14:59:14 UTC) #1
Bernhard Bauer
lgtm.
10 years, 1 month ago (2010-11-08 15:52:41 UTC) #2
Bernhard Bauer
10 years, 1 month ago (2010-11-08 15:53:34 UTC) #3 
On 2010/11/08 15:52:41, Bernhard Bauer wrote:
> lgtm.

Assuming trybots go through, that is, but you're doing that anyway, right?
Right? ;-)

Powered by Google App Engine
This is Rietveld 408576698