Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3010)

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

Issue 468193005: Remove SetAllowOverlappingView from RWHVMac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_ca_flag
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
index e0755ed054be0d26a054df6a161dcef9f84624ec..e6602e962428eafb98aed69d68c6adef4b33d1bd 100644
--- a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
@@ -46,24 +46,6 @@ class DevToolsControllerTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(DevToolsControllerTest);
};
-// Verify that AllowOverlappingViews is set while the find bar is visible.
-IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, AllowOverlappingViews) {
- OpenDevToolsWindow();
-
- // Without the find bar.
- EXPECT_TRUE(devtools_web_contents()->GetAllowOverlappingViews());
-
- // With the find bar.
- browser()->GetFindBarController()->find_bar()->Show(false);
- EXPECT_TRUE(devtools_web_contents()->GetAllowOverlappingViews());
-
- // Without the find bar.
- browser()->GetFindBarController()->find_bar()->Hide(false);
- EXPECT_TRUE(devtools_web_contents()->GetAllowOverlappingViews());
-
- CloseDevToolsWindow();
-}
-
// Verify that AllowOtherViews is set when and only when DevTools is visible.
IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, AllowOtherViews) {
EXPECT_FALSE(web_contents()->GetAllowOtherViews());
« no previous file with comments | « chrome/browser/ui/cocoa/confirm_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698