Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2312)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 468193005: Remove SetAllowOverlappingView from RWHVMac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_ca_flag
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
index 4c4f9d98efbef99eaa562f49361e62b1f868b1d0..99300210a2b397b05fca0597c93d2d8b3cc3b7f1 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
@@ -339,23 +339,6 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
shouldSuppressTopInfoBarTip]);
}
-// Verify that AllowOverlappingViews is set while the history overlay is
-// visible.
-IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
- AllowOverlappingViewsHistoryOverlay) {
- content::WebContents* web_contents =
- browser()->tab_strip_model()->GetActiveWebContents();
- EXPECT_TRUE(web_contents->GetAllowOverlappingViews());
-
- base::scoped_nsobject<HistoryOverlayController> overlay(
- [[HistoryOverlayController alloc] initForMode:kHistoryOverlayModeBack]);
- [overlay showPanelForView:web_contents->GetNativeView()];
- EXPECT_TRUE(web_contents->GetAllowOverlappingViews());
-
- overlay.reset();
- EXPECT_TRUE(web_contents->GetAllowOverlappingViews());
-}
-
// Tests that status bubble's base frame does move when devTools are docked.
IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
StatusBubblePositioning) {
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698