Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 468193002: DevTools: bring developer tools window to front when panel gets selected (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/components/InspectorView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 * @param {boolean=} forceShowInPanel 316 * @param {boolean=} forceShowInPanel
317 */ 317 */
318 showUISourceCode: function(uiSourceCode, lineNumber, columnNumber, forceShow InPanel) 318 showUISourceCode: function(uiSourceCode, lineNumber, columnNumber, forceShow InPanel)
319 { 319 {
320 this._showEditor(forceShowInPanel); 320 this._showEditor(forceShowInPanel);
321 this._sourcesView.showSourceLocation(uiSourceCode, lineNumber, columnNum ber); 321 this._sourcesView.showSourceLocation(uiSourceCode, lineNumber, columnNum ber);
322 }, 322 },
323 323
324 _showEditor: function(forceShowInPanel) 324 _showEditor: function(forceShowInPanel)
325 { 325 {
326 if (this._sourcesView.isShowing())
327 return;
328 WebInspector.inspectorView.showPanel("sources"); 326 WebInspector.inspectorView.showPanel("sources");
329 }, 327 },
330 328
331 /** 329 /**
332 * @param {!WebInspector.UILocation} uiLocation 330 * @param {!WebInspector.UILocation} uiLocation
333 * @param {boolean=} forceShowInPanel 331 * @param {boolean=} forceShowInPanel
334 */ 332 */
335 showUILocation: function(uiLocation, forceShowInPanel) 333 showUILocation: function(uiLocation, forceShowInPanel)
336 { 334 {
337 this.showUISourceCode(uiLocation.uiSourceCode, uiLocation.lineNumber, ui Location.columnNumber, forceShowInPanel); 335 this.showUISourceCode(uiLocation.uiSourceCode, uiLocation.lineNumber, ui Location.columnNumber, forceShowInPanel);
(...skipping 1011 matching lines...) Expand 10 before | Expand all | Expand 10 after
1349 */ 1347 */
1350 handleAction: function() 1348 handleAction: function()
1351 { 1349 {
1352 var panel = /** @type {?WebInspector.SourcesPanel} */ (WebInspector.insp ectorView.showPanel("sources")); 1350 var panel = /** @type {?WebInspector.SourcesPanel} */ (WebInspector.insp ectorView.showPanel("sources"));
1353 if (!panel) 1351 if (!panel)
1354 return false; 1352 return false;
1355 panel.togglePause(); 1353 panel.togglePause();
1356 return true; 1354 return true;
1357 } 1355 }
1358 } 1356 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/components/InspectorView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698