Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 468193002: DevTools: bring developer tools window to front when panel gets selected (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: bring developer tools window to front when panel gets selected This patch is a hackish way to bring developer tools front-end to front whenever Toolbox revealer asks to reveal something. BUG=399259 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/devtools/front_end/components/InspectorView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
lushnikov
6 years, 4 months ago (2014-08-13 14:40:23 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-13 14:43:03 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-13 14:51:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/468193002/1
6 years, 4 months ago (2014-08-13 14:51:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 16:04:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 16:50:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22584)
6 years, 4 months ago (2014-08-13 16:50:11 UTC) #7
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-13 18:16:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/468193002/1
6 years, 4 months ago (2014-08-13 18:17:35 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 19:45:10 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 20:15:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 180202

Powered by Google App Engine
This is Rietveld 408576698