Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 468183002: Move matching Element traversal functions from LiveNodeListBase to ElementTraversal (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Move matching Element traversal functions from LiveNodeListBase to ElementTraversal Move matching Element traversal functions from LiveNodeListBase to ElementTraversal and generalized them a bit so that they can be reused in the rest of the code base. LiveNodeListBase exists so that code can be shared between LiveNodeList and HTMLCollection. However, the ElementTraversal class is a better place to share DOM Tree traversal utility functions. It is quite common in the code base that we want to traverse Elements that match a specific rule so this will reduce code duplication once the rest of the code is ported to these new ElementTraversal functions. R=adamk@chromium.org, esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180227

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Make Element argument const #

Patch Set 4 : Clean up #

Total comments: 4

Patch Set 5 : Use anonymous namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -135 lines) Patch
M Source/core/dom/ElementTraversal.h View 11 chunks +96 lines, -0 lines 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 2 3 4 2 chunks +24 lines, -10 lines 0 comments Download
M Source/core/dom/LiveNodeListBase.h View 2 chunks +10 lines, -60 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 3 4 6 chunks +43 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
https://codereview.chromium.org/468183002/diff/20001/Source/core/dom/LiveNodeList.cpp File Source/core/dom/LiveNodeList.cpp (right): https://codereview.chromium.org/468183002/diff/20001/Source/core/dom/LiveNodeList.cpp#newcode34 Source/core/dom/LiveNodeList.cpp:34: bool operator() (Element& element) const Should this be const?
6 years, 4 months ago (2014-08-13 15:10:03 UTC) #1
Inactive
https://codereview.chromium.org/468183002/diff/20001/Source/core/dom/LiveNodeList.cpp File Source/core/dom/LiveNodeList.cpp (right): https://codereview.chromium.org/468183002/diff/20001/Source/core/dom/LiveNodeList.cpp#newcode34 Source/core/dom/LiveNodeList.cpp:34: bool operator() (Element& element) const On 2014/08/13 15:10:03, rwlbuis ...
6 years, 4 months ago (2014-08-13 15:11:28 UTC) #2
adamk
https://codereview.chromium.org/468183002/diff/60001/Source/core/dom/LiveNodeList.cpp File Source/core/dom/LiveNodeList.cpp (right): https://codereview.chromium.org/468183002/diff/60001/Source/core/dom/LiveNodeList.cpp#newcode28 Source/core/dom/LiveNodeList.cpp:28: class IsMatch { This should be in an anonymous ...
6 years, 4 months ago (2014-08-13 20:53:55 UTC) #3
Inactive
https://codereview.chromium.org/468183002/diff/60001/Source/core/dom/LiveNodeList.cpp File Source/core/dom/LiveNodeList.cpp (right): https://codereview.chromium.org/468183002/diff/60001/Source/core/dom/LiveNodeList.cpp#newcode28 Source/core/dom/LiveNodeList.cpp:28: class IsMatch { On 2014/08/13 20:53:55, adamk wrote: > ...
6 years, 4 months ago (2014-08-13 21:17:20 UTC) #4
adamk
lgtm
6 years, 4 months ago (2014-08-13 22:13:06 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-13 22:19:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/468183002/80001
6 years, 4 months ago (2014-08-13 22:21:01 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 03:53:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (80001) as 180227

Powered by Google App Engine
This is Rietveld 408576698