Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 468133002: Split Screen mode implementation. (Closed)

Created:
6 years, 4 months ago by mfomitchev
Modified:
6 years, 4 months ago
Reviewers:
oshima, Jun Mukai, sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Split Screen mode implementation. Implements Split Screen mode and window cycling behavior. Resubmit of https://codereview.chromium.org/420603011/ TBR=oshima@chromium.org,mukai@chromium.org BUG=383421 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289392

Patch Set 1 #

Patch Set 2 : Asan fix. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -94 lines) Patch
M athena/athena.gyp View 1 chunk +5 lines, -2 lines 0 comments Download
M athena/wm/bezel_controller.h View 2 chunks +7 lines, -5 lines 0 comments Download
M athena/wm/bezel_controller.cc View 11 chunks +51 lines, -33 lines 0 comments Download
A athena/wm/mru_window_tracker.h View 1 chunk +49 lines, -0 lines 0 comments Download
A athena/wm/mru_window_tracker.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A athena/wm/public/window_list_provider.h View 1 chunk +27 lines, -0 lines 0 comments Download
M athena/wm/public/window_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/wm/public/window_manager_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/wm/split_view_controller.h View 1 chunk +77 lines, -2 lines 0 comments Download
M athena/wm/split_view_controller.cc View 1 chunk +246 lines, -2 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 1 2 7 chunks +21 lines, -4 lines 0 comments Download
M athena/wm/window_overview_mode.h View 2 chunks +3 lines, -4 lines 0 comments Download
M athena/wm/window_overview_mode.cc View 1 2 13 chunks +23 lines, -40 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-13 13:05:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/468133002/20001
6 years, 4 months ago (2014-08-13 13:06:10 UTC) #2
mfomitchev
The CQ bit was unchecked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-13 13:28:33 UTC) #3
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-13 14:01:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/468133002/40001
6 years, 4 months ago (2014-08-13 14:02:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 16:22:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 16:43:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/5310)
6 years, 4 months ago (2014-08-13 16:43:40 UTC) #8
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-13 16:52:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/468133002/40001
6 years, 4 months ago (2014-08-13 16:53:18 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 17:18:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 18:15:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/5310)
6 years, 4 months ago (2014-08-13 18:15:48 UTC) #13
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-13 18:54:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/468133002/40001
6 years, 4 months ago (2014-08-13 18:54:48 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 19:23:08 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 19:59:09 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/5310)
6 years, 4 months ago (2014-08-13 19:59:10 UTC) #18
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 4 months ago (2014-08-13 20:20:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/468133002/40001
6 years, 4 months ago (2014-08-13 20:21:25 UTC) #20
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 22:03:17 UTC) #21
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 289392

Powered by Google App Engine
This is Rietveld 408576698