Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 468113003: git-sync-deps handles recursive DEPS (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

git-sync-deps handles recursive DEPS NOTRY=true Committed: https://skia.googlesource.com/skia/+/5164a979a050b015e18322690ab4bb14885e599b

Patch Set 1 : Another Patch Set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/git-sync-deps View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hal.canary
ptal
6 years, 4 months ago (2014-08-21 18:07:37 UTC) #1
borenet
Code LGTM. Standard caveat/warning about this being unsupported, etc.
6 years, 4 months ago (2014-08-21 18:08:45 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-21 18:09:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/468113003/20001
6 years, 4 months ago (2014-08-21 18:10:40 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:17:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (20001) as 5164a979a050b015e18322690ab4bb14885e599b

Powered by Google App Engine
This is Rietveld 408576698