Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: net/base/trace_net_log_observer.h

Issue 468083004: Use NESTABLE_ASYNC APIs to get NetLog data into Tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Filtered trace events in unittests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/trace_net_log_observer.h
diff --git a/net/base/trace_net_log_observer.h b/net/base/trace_net_log_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..d0757c4c5579ea08c91c73c43746181b0455afef
--- /dev/null
+++ b/net/base/trace_net_log_observer.h
@@ -0,0 +1,49 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_BASE_TRACE_NET_LOG_OBSERVER_H_
+#define NET_BASE_TRACE_NET_LOG_OBSERVER_H_
+
+#include "base/debug/trace_event_impl.h"
+#include "base/macros.h"
+#include "net/base/net_export.h"
+#include "net/base/net_log.h"
+
+namespace net {
+
+// TraceNetLogObserver watches for Trace enable, and sends NetLog
mmenke 2014/09/03 19:12:10 nit: "Trace enable" -> "trace enable" or "TraceLo
xunjieli 2014/09/08 14:08:41 Done.
+// events to TraceLog if it is enabled.
+class NET_EXPORT TraceNetLogObserver
+ : public NetLog::ThreadSafeObserver,
+ public base::debug::TraceLog::EnabledStateObserver {
mmenke 2014/09/03 19:12:10 Per email comment, EnabledStateObserver is not dec
xunjieli 2014/09/08 14:08:41 Acknowledged. The deadlock problem has been fixed
+ public:
+ TraceNetLogObserver();
+ virtual ~TraceNetLogObserver();
+
+ // net::NetLog::ThreadSafeObserver implementation:
+ virtual void OnAddEntry(const NetLog::Entry& entry) OVERRIDE;
+
+ // Start to watch for TraceLog enable and disable events.
+ // This can't be called if already watching for events.
+ // Watches NetLog only when tracing is enabled.
+ void WatchForTraceStart(NetLog* net_log);
+
+ // Stop watching for TraceLog enable and disable events.
+ // If WatchForTraceStart is called, this must be called before
+ // TraceNetLogObserver is destroyed.
+ void StopWatchForTraceStart();
+
+ // base::debug::TraceLog::EnabledStateChangedObserver implementation:
+ virtual void OnTraceLogEnabled() OVERRIDE;
+ virtual void OnTraceLogDisabled() OVERRIDE;
+
+ private:
+ NetLog* net_log_to_watch_;
+
+ DISALLOW_COPY_AND_ASSIGN(TraceNetLogObserver);
+};
+
+} // namespace net
+
+#endif // NET_BASE_TRACE_NET_LOG_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698