Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 468083002: Reapply: [oilpan]: Change marking to do precise roots first and conservative (Closed)

Created:
6 years, 4 months ago by Mads Ager (chromium)
Modified:
6 years, 4 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

Reapply: https://codereview.chromium.org/405403003/ This change did not contain the bug it just made it much more likely that we would see it. Reapplying (again). :) original description: "[oilpan]: Change marking to do precise roots first and conservative second. This way we avoid conservatively scanning objects that were reachable through precise pointers." Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180188

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -35 lines) Patch
M Source/platform/heap/Heap.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/heap/Heap.cpp View 1 4 chunks +42 lines, -11 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 2 chunks +7 lines, -2 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 4 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mads Ager (chromium)
Created Revert of Revert of Revert "Revert of [oilpan]: Change marking to do precise roots ...
6 years, 4 months ago (2014-08-13 11:20:36 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-13 11:23:11 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 4 months ago (2014-08-13 14:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/468083002/150001
6 years, 4 months ago (2014-08-13 14:30:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 15:40:01 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 16:19:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (150001) as 180188

Powered by Google App Engine
This is Rietveld 408576698