Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Side by Side Diff: src/objects.h

Issue 468073002: Rewrite DeleteProperty using the LookupIterator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assert-scope.h" 9 #include "src/assert-scope.h"
10 #include "src/builtins.h" 10 #include "src/builtins.h"
(...skipping 2689 matching lines...) Expand 10 before | Expand all | Expand 10 after
2700 PropertyAttributes attributes); 2700 PropertyAttributes attributes);
2701 2701
2702 MUST_USE_RESULT static MaybeHandle<Object> DeleteProperty( 2702 MUST_USE_RESULT static MaybeHandle<Object> DeleteProperty(
2703 Handle<JSObject> object, 2703 Handle<JSObject> object,
2704 Handle<Name> name, 2704 Handle<Name> name,
2705 DeleteMode mode); 2705 DeleteMode mode);
2706 static Handle<Object> DeletePropertyPostInterceptor(Handle<JSObject> object, 2706 static Handle<Object> DeletePropertyPostInterceptor(Handle<JSObject> object,
2707 Handle<Name> name, 2707 Handle<Name> name,
2708 DeleteMode mode); 2708 DeleteMode mode);
2709 MUST_USE_RESULT static MaybeHandle<Object> DeletePropertyWithInterceptor( 2709 MUST_USE_RESULT static MaybeHandle<Object> DeletePropertyWithInterceptor(
2710 Handle<JSObject> object, 2710 Handle<JSObject> object, Handle<JSObject> receiver, Handle<Name> name);
Jakob Kummerow 2014/08/13 12:07:25 nit: please use matching names in declaration and
2711 Handle<Name> name);
2712 2711
2713 // Deletes the named property in a normalized object. 2712 // Deletes the named property in a normalized object.
2714 static Handle<Object> DeleteNormalizedProperty(Handle<JSObject> object, 2713 static Handle<Object> DeleteNormalizedProperty(Handle<JSObject> object,
2715 Handle<Name> name, 2714 Handle<Name> name,
2716 DeleteMode mode); 2715 DeleteMode mode);
2717 2716
2718 MUST_USE_RESULT static MaybeHandle<Object> DeleteElement( 2717 MUST_USE_RESULT static MaybeHandle<Object> DeleteElement(
2719 Handle<JSObject> object, 2718 Handle<JSObject> object,
2720 uint32_t index, 2719 uint32_t index,
2721 DeleteMode mode); 2720 DeleteMode mode);
(...skipping 8507 matching lines...) Expand 10 before | Expand all | Expand 10 after
11229 } else { 11228 } else {
11230 value &= ~(1 << bit_position); 11229 value &= ~(1 << bit_position);
11231 } 11230 }
11232 return value; 11231 return value;
11233 } 11232 }
11234 }; 11233 };
11235 11234
11236 } } // namespace v8::internal 11235 } } // namespace v8::internal
11237 11236
11238 #endif // V8_OBJECTS_H_ 11237 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698