Revert of Split Screen mode implementation.

Revert of Split Screen mode implementation. (patchset #3 of https://codereview.chromium.org/461503002/)

Reason for revert:
Breaking "Linux Chromium OS ASan LSan Tests (3)" http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2721

Original issue's description:
> Split Screen mode implementation.
> 
> Implements Split Screen mode and window cycling behavior.
> Resubmit of https://codereview.chromium.org/420603011/
> 
> TBR=oshima@chromium.org,mukai@chromium.org
> 
> BUG=383421
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289064

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383421
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289208

[hashimoto, 2014-08-13 06:51:44]

Created Revert of Split Screen mode implementation.

[commit-bot: I haz the power, 2014-08-13 06:53:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/468053002/1

[commit-bot: I haz the power, 2014-08-13 06:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 06:55:44]

Failed to apply patch for athena/wm/window_manager_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file athena/wm/window_manager_impl.cc
  Hunk #2 succeeded at 41 with fuzz 1 (offset 2 lines).
  Hunk #3 FAILED at 71.
  Hunk #4 succeeded at 115 (offset 3 lines).
  Hunk #5 succeeded at 157 (offset 6 lines).
  Hunk #6 succeeded at 191 (offset 6 lines).
  1 out of 6 hunks FAILED -- saving rejects to file
athena/wm/window_manager_impl.cc.rej

Patch:       athena/wm/window_manager_impl.cc
Index: athena/wm/window_manager_impl.cc
diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc
index
f6488e395c14a5790d898a6e001444a2116d5300..e7cd444c3a7a19838dff65f78a30c8deca4e3b09
100644
--- a/athena/wm/window_manager_impl.cc
+++ b/athena/wm/window_manager_impl.cc
@@ -10,7 +10,6 @@
 #include "athena/input/public/accelerator_manager.h"
 #include "athena/screen/public/screen_manager.h"
 #include "athena/wm/bezel_controller.h"
-#include "athena/wm/mru_window_tracker.h"
 #include "athena/wm/public/window_manager_observer.h"
 #include "athena/wm/split_view_controller.h"
 #include "athena/wm/title_drag_controller.h"
@@ -40,8 +39,6 @@
   // WindowManager:
   virtual void ToggleOverview() OVERRIDE;
 
-  virtual bool IsOverviewModeActive() OVERRIDE;
-
  private:
   enum Command {
     COMMAND_TOGGLE_OVERVIEW,
@@ -74,16 +71,13 @@
   virtual void OnTitleDragCompleted(aura::Window* window) OVERRIDE;
   virtual void OnTitleDragCanceled(aura::Window* window) OVERRIDE;
 
-  // Should be declared first so that it is destoyed last.
-  ObserverList<WindowManagerObserver> observers_;
-
   scoped_ptr<aura::Window> container_;
-  scoped_ptr<MruWindowTracker> mru_window_tracker_;
   scoped_ptr<WindowOverviewMode> overview_;
   scoped_ptr<BezelController> bezel_controller_;
   scoped_ptr<SplitViewController> split_view_controller_;
   scoped_ptr<wm::WMState> wm_state_;
   scoped_ptr<TitleDragController> title_drag_controller_;
+  ObserverList<WindowManagerObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowManagerImpl);
 };
@@ -115,10 +109,8 @@
   container_.reset(ScreenManager::Get()->CreateDefaultContainer(params));
   container_->SetLayoutManager(new AthenaContainerLayoutManager);
   container_->AddObserver(this);
-  mru_window_tracker_.reset(new MruWindowTracker(container_.get()));
   bezel_controller_.reset(new BezelController(container_.get()));
-  split_view_controller_.reset(new SplitViewController(
-      container_.get(), mru_window_tracker_.get(), this));
+  split_view_controller_.reset(new SplitViewController());
   bezel_controller_->set_left_right_delegate(split_view_controller_.get());
   container_->AddPreTargetHandler(bezel_controller_.get());
   title_drag_controller_.reset(new TitleDragController(container_.get(),
this));
@@ -156,26 +148,15 @@
   SetInOverview(overview_.get() == NULL);
 }
 
-bool WindowManagerImpl::IsOverviewModeActive() {
-  return overview_;
-}
-
 void WindowManagerImpl::SetInOverview(bool active) {
   bool in_overview = !!overview_;
   if (active == in_overview)
     return;
 
   if (active) {
+    overview_ = WindowOverviewMode::Create(container_.get(), this);
     FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
                       OnOverviewModeEnter());
-    // Re-stack all windows in the order defined by mru_window_tracker_.
-    aura::Window::Windows window_list = mru_window_tracker_->GetWindowList();
-    aura::Window::Windows::iterator it;
-    for (it = window_list.begin(); it != window_list.end(); ++it)
-      container_->StackChildAtTop(*it);
-    overview_ = WindowOverviewMode::Create(container_.get(),
-                                           mru_window_tracker_.get(),
-                                           this);
   } else {
     overview_.reset();
     FOR_EACH_OBSERVER(WindowManagerObserver, observers_,
@@ -201,7 +182,8 @@
 }
 
 void WindowManagerImpl::OnSelectWindow(aura::Window* window) {
-  mru_window_tracker_->MoveToFront(window);
+  CHECK_EQ(container_.get(), window->parent());
+  container_->StackChildAtTop(window);
   wm::ActivateWindow(window);
   SetInOverview(false);
 }

[hashimoto, 2014-08-13 07:00:56]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-13 07:02:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/468053002/260001

[commit-bot: I haz the power, 2014-08-13 07:04:27]

Change committed as 289208