DevTools: keyboard navigation broken in the viewported Network panel

DevTools: keyboard navigation broken in the viewported Network panel

BUG=403430
R=eustas@chromium.org, lushnikov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180245

[lushnikov, 2014-08-13 19:50:25]

https://codereview.chromium.org/468043004/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/ViewportDataGrid.js (right):

https://codereview.chromium.org/468043004/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/ViewportDataGrid.js:139: if (scrollTop > fromY)
if (this._visibleNodes.indexOf(node) !== -1)
  return;

<calculate fromY>
this._scrollContainer.scrollTop = fromY;

[lushnikov, 2014-08-13 20:08:19]

lgtm

[pfeldman, 2014-08-13 20:10:08]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:11:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/468043004/1

[commit-bot: I haz the power, 2014-08-13 21:23:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19717)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22627)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/41370)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/46576)

[commit-bot: I haz the power, 2014-08-13 21:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 21:24:43]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/41414)

[eustas, 2014-08-14 05:51:30]

lgtm

[pfeldman, 2014-08-14 06:47:15]

Committed patchset #1 manually as 180245 (presubmit successful).