Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 468033002: Remove worker process related codes from ContentBrowserClient. (Closed)

Created:
6 years, 4 months ago by horo
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, extensions-reviews_chromium.org, Jiang Jiang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove worker process related codes from ContentBrowserClient. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290139

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -140 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_parts.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/browser/extensions/url_request_util.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/browser/info_map.h View 1 3 chunks +0 lines, -13 lines 0 comments Download
M extensions/browser/info_map.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
horo
thestig@ Could you please review this?
6 years, 4 months ago (2014-08-13 03:51:08 UTC) #1
Lei Zhang
lgtm, but you'll need additional OWNERS to approve.
6 years, 4 months ago (2014-08-13 04:48:05 UTC) #2
horo
avi@ Could you please review content/public/browser/content_browser_client.*? asargent@ Could you please review extensions/browser/info_map.*? benm@ Could you ...
6 years, 4 months ago (2014-08-13 05:19:47 UTC) #3
Avi (use Gerrit)
Red = good content/public/browser/content_browser_client.* LGTM
6 years, 4 months ago (2014-08-13 14:38:17 UTC) #4
asargent_no_longer_on_chrome
lgtm
6 years, 4 months ago (2014-08-13 18:52:53 UTC) #5
horo
mkosiba@ Could you please review android_webview/browser/aw_content_browser_client.*? Thank you.
6 years, 4 months ago (2014-08-14 14:08:13 UTC) #6
mkosiba (inactive)
android_webview LGTM
6 years, 4 months ago (2014-08-15 11:35:14 UTC) #7
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-16 01:51:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/468033002/1
6 years, 4 months ago (2014-08-16 01:52:43 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 02:03:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 02:04:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/4366)
6 years, 4 months ago (2014-08-16 02:04:41 UTC) #12
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-16 03:55:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/468033002/20001
6 years, 4 months ago (2014-08-16 03:56:47 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 08:33:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290139

Powered by Google App Engine
This is Rietveld 408576698