Get rid of ExternalTabAutomationProxy by switching the extension UI...

Get rid of ExternalTabAutomationProxy by switching the extension UI
tests over to ExternalTabUITest.

BUG=27326
TEST=ui_tests.exe


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33902

[stoyan, 2009-12-04 17:37:25]

lgtm

http://codereview.chromium.org/468013/diff/1/4
File chrome/browser/extensions/extension_uitest.cc (right):

http://codereview.chromium.org/468013/diff/1/4#newcode77
chrome/browser/extensions/extension_uitest.cc:77: mock_->DestroyHostWindow();
In most tests mock_->DestroyHostWindow() is already called right? so tab_'s
handle is invalid here as well as the host window.
We need a check somewhere.

http://codereview.chromium.org/468013/diff/1/4#newcode452
chrome/browser/extensions/extension_uitest.cc:452:
&ExtensionTestBrowserEvents::HandleMessageFromChrome))));
Could you please add a comment, explaining that on last message received
HandleMessageFromChrome will destroy the tab? Otherwise is not obvious how the
test ends.

http://codereview.chromium.org/468013/diff/1/2
File chrome/test/automation/automation_proxy_uitest.cc (right):

http://codereview.chromium.org/468013/diff/1/2#newcode666
chrome/test/automation/automation_proxy_uitest.cc:666: void
ExternalTabUITestMockClient::ReplyStarted(const IPC::AutomationURLResponse*
response,
80 columns

http://codereview.chromium.org/468013/diff/1/2#newcode672
chrome/test/automation/automation_proxy_uitest.cc:672: void
ExternalTabUITestMockClient::ReplyData(const std::string* data, int tab_handle,
int request_id) {
80 columns

[Jói, 2009-12-04 21:09:18]

Please take another quick look.

http://codereview.chromium.org/468013/diff/1/4
File chrome/browser/extensions/extension_uitest.cc (right):

http://codereview.chromium.org/468013/diff/1/4#newcode77
chrome/browser/extensions/extension_uitest.cc:77: mock_->DestroyHostWindow();
On 2009/12/04 17:37:26, stoyan wrote:
> In most tests mock_->DestroyHostWindow() is already called right? so tab_'s
> handle is invalid here as well as the host window.
> We need a check somewhere.

Changed it to check in TearDown that you haven't destroyed the window and
instead just ended the message loop.  This caused a few changes in
extension_uitest.cc so please take another quick look.

http://codereview.chromium.org/468013/diff/1/4#newcode452
chrome/browser/extensions/extension_uitest.cc:452:
&ExtensionTestBrowserEvents::HandleMessageFromChrome))));
On 2009/12/04 17:37:26, stoyan wrote:
> Could you please add a comment, explaining that on last message received
> HandleMessageFromChrome will destroy the tab? Otherwise is not obvious how the
> test ends.

Done.

http://codereview.chromium.org/468013/diff/1/2
File chrome/test/automation/automation_proxy_uitest.cc (right):

http://codereview.chromium.org/468013/diff/1/2#newcode666
chrome/test/automation/automation_proxy_uitest.cc:666: void
ExternalTabUITestMockClient::ReplyStarted(const IPC::AutomationURLResponse*
response,
On 2009/12/04 17:37:26, stoyan wrote:
> 80 columns

Done.

http://codereview.chromium.org/468013/diff/1/2#newcode672
chrome/test/automation/automation_proxy_uitest.cc:672: void
ExternalTabUITestMockClient::ReplyData(const std::string* data, int tab_handle,
int request_id) {
On 2009/12/04 17:37:26, stoyan wrote:
> 80 columns

Done.

[stoyan, 2009-12-04 22:06:51]

LGTM