Improve reporting of subprocess crashes....

chrome/common/child_process_info.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CHILD_PROCESS_INFO_H_
 #define CHROME_COMMON_CHILD_PROCESS_INFO_H_
 
 #include <string>
 
 #include "base/process.h"
 
 // Holds information about a child process.
 class ChildProcessInfo {
  public:
+  // NOTE: Do not remove or reorder the elements in this enum, and only add new
+  // items at the end. We depend on these specific values in a histogram.
   enum ProcessType {
+    UNKNOWN_PROCESS = 1,

[jar (doing other things), 2009/12/18 16:28:14]

This change appears to re-number all entries in this list.  
Were these entries never used before?

[asargent_no_longer_on_chrome, 2010/01/05 01:01:19]

Their ordinal values were never used before as far as I could tell, and the
history of the file shows people adding new ones in random order (not just at
the end), which doesn't appear to have been a problem.

This reminds me though - maybe I'll add a unit test that enforces the no-delete
no-reorder policy which we now depend on. 

     BROWSER_PROCESS,
     RENDER_PROCESS,
     PLUGIN_PROCESS,
     WORKER_PROCESS,
     NACL_PROCESS,
     UTILITY_PROCESS,
     PROFILE_IMPORT_PROCESS,
     ZYGOTE_PROCESS,
-    SANDBOX_HELPER_PROCESS,
-    UNKNOWN_PROCESS,
+    SANDBOX_HELPER_PROCESS
   };
 
   ChildProcessInfo(const ChildProcessInfo& original);
   virtual ~ChildProcessInfo();
 
   ChildProcessInfo& operator=(const ChildProcessInfo& original);
 
   // Returns the type of the process.
   ProcessType type() const { return type_; }
 
@@ skipping 58 matching lines @@
  private:
   ProcessType type_;
   std::wstring name_;
   int id_;
 
   // The handle to the process.
   mutable base::Process process_;
 };
 
 #endif  // CHROME_COMMON_CHILD_PROCESS_INFO_H_