Improve reporting of subprocess crashes....

chrome/browser/metrics/metrics_log.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_log.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
@@ skipping 429 matching lines @@
     WriteIntAttribute("pageloadcount", count);
     pref->SetInteger(prefs::kStabilityPageLoadCount, 0);
   }
 
   count = pref->GetInteger(prefs::kStabilityRendererCrashCount);
   if (count) {
     WriteIntAttribute("renderercrashcount", count);
     pref->SetInteger(prefs::kStabilityRendererCrashCount, 0);
   }
 
+  count = pref->GetInteger(prefs::kStabilityExtensionRendererCrashCount);
+  if (count) {
+    WriteIntAttribute("extensionrenderercrashcount", count);

[jar (doing other things), 2009/12/18 16:28:14]

Do you have corresponding changes to the protobuffer and logging code to support
this?

[asargent_no_longer_on_chrome, 2010/01/05 01:01:19]

I was under the impression that doing this here is sufficient for the client
side of things. Evan mentioned in the bug that we have someone (Jeff Bailey I
believe) working on the UMA server side, and I was planning on asking him to
make the relevant server changes. Please let me know if there's more that needs
to happen in the client than this code here which puts the new value in the xml
log. 

+    pref->SetInteger(prefs::kStabilityExtensionRendererCrashCount, 0);
+  }
+
   count = pref->GetInteger(prefs::kStabilityRendererHangCount);
   if (count) {
     WriteIntAttribute("rendererhangcount", count);
     pref->SetInteger(prefs::kStabilityRendererHangCount, 0);
   }
+
+  count = pref->GetInteger(prefs::kStabilityChildProcessCrashCount);
+  if (count) {
+    WriteIntAttribute("childprocesscrashcount", count);
+    pref->SetInteger(prefs::kStabilityChildProcessCrashCount, 0);
+  }
 }
 
 void MetricsLog::WritePluginList(
          const std::vector<WebPluginInfo>& plugin_list) {
   DCHECK(!locked_);
 
   OPEN_ELEMENT_FOR_SCOPE("plugins");
 
   for (std::vector<WebPluginInfo>::const_iterator iter = plugin_list.begin();
        iter != plugin_list.end(); ++iter) {
@@ skipping 220 matching lines @@
 
   for (size_t i = 0; i < histogram.bucket_count(); i++) {
     if (snapshot.counts(i)) {
       OPEN_ELEMENT_FOR_SCOPE("histogrambucket");
       WriteIntAttribute("min", histogram.ranges(i));
       WriteIntAttribute("max", histogram.ranges(i + 1));
       WriteIntAttribute("count", snapshot.counts(i));
     }
   }
 }