Chromium Code Reviews

Issue 467983002: Make udev target disappear on linux when use_udev==0 (Closed)

Created:
6 years, 4 months ago by spang
Modified:
6 years, 4 months ago
Reviewers:
Ken Rockot(use gerrit already), dnicoara, meacer
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make udev target disappear on linux when use_udev==0 So we don't break builds that don't use it by running pkg-config, and so we don't accidently link against it when it is disabled. The embedded=1 build has OS=="linux" use_udev==0 for small devices such as the chromecast. BUG=403162 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290377

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Stats (+69 lines, -31 lines)
M build/linux/system.gyp View 2 chunks +25 lines, -22 lines 0 comments
M chrome/chrome_browser.gypi View 1 chunk +5 lines, -1 line 0 comments
M chrome/chrome_browser_ui.gypi View 2 chunks +5 lines, -3 lines 0 comments
M components/usb_service.gypi View 1 chunk +1 line, -1 line 0 comments
M device/device_tests.gyp View 1 chunk +3 lines, -0 lines 0 comments
M device/serial/serial.gyp View 1 chunk +6 lines, -1 line 0 comments
M third_party/libusb/libusb.gyp View 1 chunk +24 lines, -3 lines 0 comments

Messages

Total messages: 9 (0 generated)
spang
6 years, 4 months ago (2014-08-13 18:29:02 UTC) #1
Ken Rockot(use gerrit already)
lgtm for //components/usb_service and //device
6 years, 4 months ago (2014-08-13 20:54:33 UTC) #2
spang
The CQ bit was checked by spang@chromium.org
6 years, 4 months ago (2014-08-18 19:40:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/467983002/20001
6 years, 4 months ago (2014-08-18 19:42:00 UTC) #4
meacer
Sorry for the late response, I reviewed this earlier but never sent it out. Lgtm.
6 years, 4 months ago (2014-08-18 19:45:11 UTC) #5
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 4 months ago (2014-08-18 19:45:39 UTC) #6
spang
The CQ bit was checked by spang@chromium.org
6 years, 4 months ago (2014-08-18 19:45:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/467983002/20001
6 years, 4 months ago (2014-08-18 19:46:10 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 22:14:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290377

Powered by Google App Engine