Issue 467973003: Use an AtomicString as key in DocumentOrderedMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467973003: Use an AtomicString as key in DocumentOrderedMap (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
Hajime Morrita, esprehn

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, inferno, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use an AtomicString as key in DocumentOrderedMap Use an AtomicString as key in DocumentOrderedMap instead of a StringImpl*. This is safer as the HashMap Traits rely on the StringImpl* to not be a dangling pointer (it is calling StringImpl::hash()). Using an AtomicString as key will make sure we don't experience use-after-free such as in Bug 402255. I ran Bindings/get-element-by-id.html test and did not see any performance regression. R=esprehn@chromium.org, morrita@chromium.org BUG=402255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180365

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	Source/core/dom/DocumentOrderedMap.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	Source/core/dom/DocumentOrderedMap.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/467973003/1

6 years, 4 months ago (2014-08-15 14:44:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180365

Expand Messages | Collapse Messages