Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 467963002: Refactoring: Create per-connection packet writers in QuicDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase onto ToT Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/tools/quic/quic_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 0c86d033e6875a820d745f86b38439b43b040de0..e29f870772dd0a813af048b9f7631eb5c9c83ffa 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -161,11 +161,17 @@ vector<TestParams> GetTestParams() {
class ServerDelegate : public PacketDroppingTestWriter::Delegate {
public:
- explicit ServerDelegate(QuicDispatcher* dispatcher)
- : dispatcher_(dispatcher) {}
+ ServerDelegate(TestWriterFactory* writer_factory,
+ QuicDispatcher* dispatcher)
+ : writer_factory_(writer_factory),
+ dispatcher_(dispatcher) {}
virtual ~ServerDelegate() {}
+ virtual void OnPacketSent(WriteResult result) override {
+ writer_factory_->OnPacketSent(result);
+ }
virtual void OnCanWrite() OVERRIDE { dispatcher_->OnCanWrite(); }
private:
+ TestWriterFactory* writer_factory_;
QuicDispatcher* dispatcher_;
};
@@ -173,6 +179,7 @@ class ClientDelegate : public PacketDroppingTestWriter::Delegate {
public:
explicit ClientDelegate(QuicClient* client) : client_(client) {}
virtual ~ClientDelegate() {}
+ virtual void OnPacketSent(WriteResult result) OVERRIDE {}
virtual void OnCanWrite() OVERRIDE {
EpollEvent event(EPOLLOUT, false);
client_->OnEvent(client_->fd(), &event);
@@ -327,7 +334,7 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
virtual void SetUp() OVERRIDE {
// The ownership of these gets transferred to the QuicPacketWriterWrapper
- // and QuicDispatcher when Initialize() is executed.
+ // and TestWriterFactory when Initialize() is executed.
client_writer_ = new PacketDroppingTestWriter();
server_writer_ = new PacketDroppingTestWriter();
}
@@ -347,10 +354,13 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
server_thread_->GetPort());
QuicDispatcher* dispatcher =
QuicServerPeer::GetDispatcher(server_thread_->server());
+ TestWriterFactory* packet_writer_factory = new TestWriterFactory();
+ QuicDispatcherPeer::SetPacketWriterFactory(dispatcher,
+ packet_writer_factory);
QuicDispatcherPeer::UseWriter(dispatcher, server_writer_);
server_writer_->Initialize(
QuicDispatcherPeer::GetHelper(dispatcher),
- new ServerDelegate(dispatcher));
+ new ServerDelegate(packet_writer_factory, dispatcher));
server_thread_->Start();
server_started_ = true;
}
@@ -1155,7 +1165,7 @@ TEST_P(EndToEndTest, ConnectionMigrationClientIPChanged) {
writer->set_writer(new QuicDefaultPacketWriter(client_->client()->fd()));
QuicConnectionPeer::SetWriter(client_->client()->session()->connection(),
writer,
- true /* owns_writer */);
+ /* owns_writer= */ true);
client_->SendSynchronousRequest("/bar");
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/tools/quic/quic_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698