net/quic/quic_connection.cc - Issue 467963002: Refactoring: Create per-connection packet writers in QuicDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection.cc

Issue 467963002: Refactoring: Create per-connection packet writers in QuicDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_connection.cc

diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc

index f40b34dfe590af5b07e40d2d6115ad8c8e69a2ba..946ce13910bd3316124176ef2f5b3842fb16b8ea 100644

--- a/net/quic/quic_connection.cc

+++ b/net/quic/quic_connection.cc

@@ -190,14 +190,14 @@ QuicConnection::QueuedPacket::QueuedPacket(SerializedPacket packet,

QuicConnection::QuicConnection(QuicConnectionId connection_id,

IPEndPoint address,

QuicConnectionHelperInterface* helper,

- QuicPacketWriter* writer,

+ const PacketWriterFactory& writer_factory,

bool owns_writer,

bool is_server,

const QuicVersionVector& supported_versions)

: framer_(supported_versions, helper->GetClock()->ApproximateNow(),

is_server),

helper_(helper),

- writer_(writer),

+ writer_(writer_factory.Create(this)),

owns_writer_(owns_writer),

encryption_level_(ENCRYPTION_NONE),

clock_(helper->GetClock()),

« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | net/quic/quic_connection_test.cc » ('J')