Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: net/quic/quic_per_connection_packet_writer.h

Issue 467963002: Refactoring: Create per-connection packet writers in QuicDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_ 5 #ifndef NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_
6 #define NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_ 6 #define NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "net/base/ip_endpoint.h" 10 #include "net/base/ip_endpoint.h"
11 #include "net/quic/quic_connection.h" 11 #include "net/quic/quic_connection.h"
12 #include "net/quic/quic_packet_writer.h" 12 #include "net/quic/quic_packet_writer.h"
13 #include "net/quic/quic_protocol.h" 13 #include "net/quic/quic_protocol.h"
14 #include "net/quic/quic_types.h" 14 #include "net/quic/quic_types.h"
15 15
16 namespace net { 16 namespace net {
17 17
18 class QuicServerPacketWriter; 18 class QuicServerPacketWriter;
19 19
20 // A connection-specific packet writer that notifies its connection when its 20 // A connection-specific packet writer that notifies its connection when its
21 // writes to the shared QuicServerPacketWriter complete. 21 // writes to the shared QuicServerPacketWriter complete.
22 // This class is necessary because multiple connections can share the same 22 // This class is necessary because multiple connections can share the same
23 // QuicServerPacketWriter, so it has no way to know which connection to notify. 23 // QuicServerPacketWriter, so it has no way to know which connection to notify.
24 // TODO(dmz) Try to merge with Chrome's default packet writer
25 class QuicPerConnectionPacketWriter : public QuicPacketWriter { 24 class QuicPerConnectionPacketWriter : public QuicPacketWriter {
26 public: 25 public:
27 QuicPerConnectionPacketWriter(QuicServerPacketWriter* writer); 26 // Does not take ownership of |shared_writer| or |connection|.
27 QuicPerConnectionPacketWriter(QuicServerPacketWriter* shared_writer,
28 QuicConnection* connection);
28 virtual ~QuicPerConnectionPacketWriter(); 29 virtual ~QuicPerConnectionPacketWriter();
29 30
30 // Set the connection to notify after writes complete. 31 QuicPacketWriter* shared_writer() const;
31 void set_connection(QuicConnection* connection) { connection_ = connection; } 32 QuicConnection* connection() const { return connection_; }
32 33
33 // QuicPacketWriter 34 // QuicPacketWriter
34 virtual WriteResult WritePacket(const char* buffer, 35 virtual WriteResult WritePacket(const char* buffer,
35 size_t buf_len, 36 size_t buf_len,
36 const IPAddressNumber& self_address, 37 const IPAddressNumber& self_address,
37 const IPEndPoint& peer_address) OVERRIDE; 38 const IPEndPoint& peer_address) OVERRIDE;
38 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE; 39 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;
39 virtual bool IsWriteBlocked() const OVERRIDE; 40 virtual bool IsWriteBlocked() const OVERRIDE;
40 virtual void SetWritable() OVERRIDE; 41 virtual void SetWritable() OVERRIDE;
41 42
42 private: 43 private:
43 void OnWriteComplete(WriteResult result); 44 void OnWriteComplete(WriteResult result);
44 45
45 base::WeakPtrFactory<QuicPerConnectionPacketWriter> weak_factory_; 46 base::WeakPtrFactory<QuicPerConnectionPacketWriter> weak_factory_;
46 QuicServerPacketWriter* writer_; // Not owned. 47 QuicServerPacketWriter* shared_writer_; // Not owned.
47 QuicConnection* connection_; 48 QuicConnection* connection_; // Not owned.
48 49
49 DISALLOW_COPY_AND_ASSIGN(QuicPerConnectionPacketWriter); 50 DISALLOW_COPY_AND_ASSIGN(QuicPerConnectionPacketWriter);
50 }; 51 };
51 52
52 } // namespace net 53 } // namespace net
53 54
54 #endif // NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_ 55 #endif // NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698