Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: Source/core/testing/DummyPageHolder.h

Issue 467943005: Allow passing mock FrameLoaderClient to DummyPageHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/streams/ReadableStreamTest.cpp ('k') | Source/core/testing/DummyPageHolder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/DummyPageHolder.h
diff --git a/Source/core/testing/DummyPageHolder.h b/Source/core/testing/DummyPageHolder.h
index 24226902fca8c865b8c8be40a93b008ae250fba0..fe658f04a5686406bec89b5f9236929bb9f05134 100644
--- a/Source/core/testing/DummyPageHolder.h
+++ b/Source/core/testing/DummyPageHolder.h
@@ -31,7 +31,7 @@
#ifndef DummyPageHolder_h
#define DummyPageHolder_h
-#include "core/loader/EmptyClients.h"
+#include "core/loader/FrameLoaderClient.h"
#include "core/page/Page.h"
#include "platform/geometry/IntSize.h"
#include "platform/heap/Handle.h"
@@ -60,7 +60,10 @@ class DummyPageHolder {
WTF_MAKE_NONCOPYABLE(DummyPageHolder);
WTF_MAKE_FAST_ALLOCATED;
public:
- static PassOwnPtr<DummyPageHolder> create(const IntSize& initialViewSize = IntSize(), Page::PageClients* = 0);
+ static PassOwnPtr<DummyPageHolder> create(
+ const IntSize& initialViewSize = IntSize(),
+ Page::PageClients* = 0,
+ PassOwnPtr<FrameLoaderClient> = PassOwnPtr<FrameLoaderClient>());
~DummyPageHolder();
Page& page() const;
@@ -69,13 +72,16 @@ public:
Document& document() const;
private:
- explicit DummyPageHolder(const IntSize& initialViewSize, Page::PageClients*);
+ explicit DummyPageHolder(
+ const IntSize& initialViewSize,
+ Page::PageClients*,
+ PassOwnPtr<FrameLoaderClient>);
OwnPtrWillBePersistent<Page> m_page;
RefPtr<LocalFrame> m_frame;
Page::PageClients m_pageClients;
- EmptyFrameLoaderClient m_frameLoaderClient;
+ OwnPtr<FrameLoaderClient> m_frameLoaderClient;
};
} // namespace blink
« no previous file with comments | « Source/core/streams/ReadableStreamTest.cpp ('k') | Source/core/testing/DummyPageHolder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698