Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 467943005: Allow passing mock FrameLoaderClient to DummyPageHolder. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
Reviewers:
dcheng, abarth-chromium
CC:
abarth-chromium, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, gavinp+loader_chromium.org, Nate Chapin, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Allow passing mock FrameLoaderClient to DummyPageHolder. This CL has three parts: - DummyPageHolder can be created with a given FrameLoaderClient instance. - EmptyFrameLoaderClient is no longer FINAL so it can be used for mocks. - fix dependency breakage following the move of EmptyClients.h in the cpp. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181312

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/SurroundingTextTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContextTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderingTestHelper.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/streams/ReadableStreamTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/DummyPageHolder.h View 3 chunks +10 lines, -4 lines 0 comments Download
M Source/core/testing/DummyPageHolder.cpp View 2 chunks +15 lines, -5 lines 0 comments Download
M Source/modules/websockets/DOMWebSocketTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImplTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebNodeTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-08-25 16:29:46 UTC) #1
mlamouri (slow - plz ping)
Review ping. Let me know if you want me to not move "EmptyClients.h" out of ...
6 years, 3 months ago (2014-08-27 17:15:45 UTC) #2
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-02 00:12:14 UTC) #3
mlamouri (slow - plz ping)
dcheng@, do you think this would be interesting to have even though I will not ...
6 years, 3 months ago (2014-09-02 08:51:57 UTC) #5
abarth-chromium
6 years, 3 months ago (2014-09-02 19:33:04 UTC) #6
mlamouri (slow - plz ping)
On 2014/09/02 19:33:04, abarth wrote: Adam, you left a blank comment, I assume that wasn't ...
6 years, 3 months ago (2014-09-02 21:33:36 UTC) #7
abarth-chromium
Sorry, I meant to LGTM
6 years, 3 months ago (2014-09-02 21:45:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/467943005/20001
6 years, 3 months ago (2014-09-03 10:46:53 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 3 months ago (2014-09-03 11:55:23 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 13:06:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181312

Powered by Google App Engine
This is Rietveld 408576698