Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 467923003: Add ServiceManagement*() and their tests (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@process_util
Project:
crashpad
Visibility:
Public.

Description

Add ServiceManagement*() and their tests. TEST=util_test ServiceManagement R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a70edb3b7f55

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : ServiceManagement-based implementation #

Patch Set 4 : Drop the ServiceManagement-based implementation, and update comments to reflect the current 10.10 DP5 #

Patch Set 5 : Hey, where’d that line go? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -0 lines) Patch
A util/mac/service_management.h View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
A util/mac/service_management.cc View 1 2 3 1 chunk +139 lines, -0 lines 0 comments Download
A util/mac/service_management_test.mm View 1 2 3 4 1 chunk +167 lines, -0 lines 0 comments Download
M util/util.gyp View 1 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/461253002/.
6 years, 4 months ago (2014-08-12 23:42:39 UTC) #1
Robert Sesek
https://codereview.chromium.org/467923003/diff/1/util/mac/service_management.h File util/mac/service_management.h (right): https://codereview.chromium.org/467923003/diff/1/util/mac/service_management.h#newcode42 util/mac/service_management.h:42: //! \return `true` if the job was removed successfully, ...
6 years, 4 months ago (2014-08-14 20:27:22 UTC) #2
Mark Mentovai
Feedback addressed. I retested on 10.10 DP5 14A314h and found that it was the same ...
6 years, 4 months ago (2014-08-14 22:51:59 UTC) #3
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-15 21:33:12 UTC) #4
Mark Mentovai
6 years, 4 months ago (2014-08-16 05:30:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as a70edb3b7f55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698