Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 467853002: Suppress the upgrade tutorial for new profile (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Suppress the upgrade tutorial for new profile BUG=403033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289590

Patch Set 1 #

Total comments: 2

Patch Set 2 : roger's comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M chrome/browser/profiles/profile_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 4 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 4 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
guohui
Hey, sky@ for owner review of chrome\browser\ui\... noms@ for owner review of profile_impl.cc rogerta@ for ...
6 years, 4 months ago (2014-08-12 20:55:50 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-12 22:43:03 UTC) #2
guohui
ping roger and monica?
6 years, 4 months ago (2014-08-13 19:30:29 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/467853002/diff/1/chrome/browser/signin/signin_ui_util.cc File chrome/browser/signin/signin_ui_util.cc (right): https://codereview.chromium.org/467853002/diff/1/chrome/browser/signin/signin_ui_util.cc#newcode164 chrome/browser/signin/signin_ui_util.cc:164: profile->GetPrefs()->SetInteger(prefs::kProfileAvatarTutorialShown, 2); Move kUpgradeWelcomeTutorialShowMax to the header so ...
6 years, 4 months ago (2014-08-13 20:18:22 UTC) #4
noms (inactive)
profiles lgtm
6 years, 4 months ago (2014-08-13 20:38:20 UTC) #5
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-13 20:47:06 UTC) #6
guohui
https://codereview.chromium.org/467853002/diff/1/chrome/browser/signin/signin_ui_util.cc File chrome/browser/signin/signin_ui_util.cc (right): https://codereview.chromium.org/467853002/diff/1/chrome/browser/signin/signin_ui_util.cc#newcode164 chrome/browser/signin/signin_ui_util.cc:164: profile->GetPrefs()->SetInteger(prefs::kProfileAvatarTutorialShown, 2); On 2014/08/13 20:18:21, Roger Tawa wrote: > ...
6 years, 4 months ago (2014-08-13 20:49:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/467853002/20001
6 years, 4 months ago (2014-08-13 20:49:32 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 08:56:19 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:15:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289590

Powered by Google App Engine
This is Rietveld 408576698