Issue 467813002: Round the snapped position when checking snapped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467813002: Round the snapped position when checking snapped (Closed)

Created:
6 years, 4 months ago by oshima

Modified:
6 years, 4 months ago

Reviewers:
danakj

CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Round the snapped position when checking snapped so that it can handle negative errors (like 0.999) BUG=None R=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289105

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/compositor/dip_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/467813002/1

6 years, 4 months ago (2014-08-12 20:38:27 UTC) #4

Message was sent while issue was closed.

Change committed as 289105

Expand Messages | Collapse Messages