Issue 467753002: Deleting deprecated copresence protos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467753002: Deleting deprecated copresence protos (Closed)

Created:
6 years, 4 months ago by Charlie

Modified:
6 years, 4 months ago

Reviewers:
rkc

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

We have recently removed usage of these deprecated fields from the code. This CL removes them from the protos too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289130

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -35 lines)			Patch
M	components/copresence/proto/data.proto	View	1	5 chunks	+0 lines, -18 lines	0 comments	Download
M	components/copresence/proto/enums.proto	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	components/copresence/proto/identity.proto	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	components/copresence/proto/rpcs.proto	View		3 chunks	+0 lines, -9 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckehoe@chromium.org/467753002/20001

6 years, 4 months ago (2014-08-12 18:32:24 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-12 22:15:40 UTC) #5

Message was sent while issue was closed.

Change committed as 289130