Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 467683003: Add missing DRAW_PICTURE_MATRIX_PAINT paint offset. (Closed)

Created:
6 years, 4 months ago by f(malita)
Modified:
6 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add missing DRAW_PICTURE_MATRIX_PAINT paint offset. Also remove explicit gPaintOffsets sizing to make the existing compile time size check effective. R=reed@google.com,robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/9f49cfdbf6493b953775890d7f9c97a1dce0d341

Patch Set 1 #

Patch Set 2 : write/read paint first #

Patch Set 3 : New order: paint->matrix->picture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/core/SkPicturePlayback.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
f(malita)
Would be much nicer to move the paint upfront (to avoid relying on SkMatrix sizeInMemory), ...
6 years, 4 months ago (2014-08-12 17:03:22 UTC) #1
robertphillips
lgtm
6 years, 4 months ago (2014-08-12 17:05:26 UTC) #2
f(malita)
On 2014/08/12 17:05:26, robertphillips wrote: > lgtm Updated to serialize paint first - PTAL.
6 years, 4 months ago (2014-08-12 17:18:16 UTC) #3
robertphillips
You don't want to move the matrix forward too?
6 years, 4 months ago (2014-08-12 17:26:15 UTC) #4
f(malita)
On 2014/08/12 17:26:15, robertphillips wrote: > You don't want to move the matrix forward too? ...
6 years, 4 months ago (2014-08-12 17:38:39 UTC) #5
robertphillips
lgtm
6 years, 4 months ago (2014-08-12 19:16:01 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 4 months ago (2014-08-12 19:18:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/467683003/40001
6 years, 4 months ago (2014-08-12 19:19:25 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 19:24:25 UTC) #9
Message was sent while issue was closed.
Change committed as 9f49cfdbf6493b953775890d7f9c97a1dce0d341

Powered by Google App Engine
This is Rietveld 408576698