Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 467653002: Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index 5afc0df7e153beaf2d048ba62dab442e9dcf51cf..d20a8b793505146e0fd147a43f5623a50f1bc9d1 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -17,47 +17,53 @@
namespace content {
-class BrowserContext;
-
// Describes interface for managing devtools agents from the browser process.
class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
public:
+ class CONTENT_EXPORT CloseListener {
+ public:
+ virtual void AgentHostClosing(DevToolsAgentHostImpl*) = 0;
+ protected:
+ virtual ~CloseListener() {}
+ };
+
// Informs the hosted agent that a client host has attached.
virtual void Attach() = 0;
// Informs the hosted agent that a client host has detached.
virtual void Detach() = 0;
- // Sends a message to the agent.
- virtual void DispatchProtocolMessage(const std::string& message) = 0;
+ // Sends a message to the agent hosted by this object.
+ virtual void DispatchOnInspectorBackend(const std::string& message) = 0;
- // Opens the inspector for this host.
- void Inspect(BrowserContext* browser_context);
+ void set_close_listener(CloseListener* listener) {
+ close_listener_ = listener;
+ }
// DevToolsAgentHost implementation.
- virtual void AttachClient(DevToolsAgentHostClient* client) OVERRIDE;
- virtual void DetachClient() OVERRIDE;
virtual bool IsAttached() OVERRIDE;
+
virtual void InspectElement(int x, int y) OVERRIDE;
+
virtual std::string GetId() OVERRIDE;
+
virtual WebContents* GetWebContents() OVERRIDE;
+
virtual void DisconnectWebContents() OVERRIDE;
- virtual void ConnectWebContents(WebContents* wc) OVERRIDE;
+
+ virtual void ConnectWebContents(WebContents* rvh) OVERRIDE;
+
virtual bool IsWorker() const OVERRIDE;
protected:
DevToolsAgentHostImpl();
virtual ~DevToolsAgentHostImpl();
- void HostClosed();
- void SendMessageToClient(const std::string& message);
- static void NotifyCallbacks(DevToolsAgentHostImpl* agent_host, bool attached);
+ void NotifyCloseListener();
private:
- friend class DevToolsAgentHost; // for static methods
-
+ CloseListener* close_listener_;
const std::string id_;
- DevToolsAgentHostClient* client_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698