Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: apps/app_window_registry.cc

Issue 467653002: Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/app_window_registry.h" 5 #include "apps/app_window_registry.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "apps/app_window.h" 10 #include "apps/app_window.h"
11 #include "apps/ui/apps_client.h" 11 #include "apps/ui/apps_client.h"
12 #include "apps/ui/native_app_window.h" 12 #include "apps/ui/native_app_window.h"
13 #include "components/keyed_service/content/browser_context_dependency_manager.h" 13 #include "components/keyed_service/content/browser_context_dependency_manager.h"
14 #include "content/public/browser/browser_context.h" 14 #include "content/public/browser/browser_context.h"
15 #include "content/public/browser/devtools_agent_host.h" 15 #include "content/public/browser/devtools_agent_host.h"
16 #include "content/public/browser/devtools_manager.h"
16 #include "content/public/browser/render_process_host.h" 17 #include "content/public/browser/render_process_host.h"
17 #include "content/public/browser/render_view_host.h" 18 #include "content/public/browser/render_view_host.h"
18 #include "content/public/browser/site_instance.h" 19 #include "content/public/browser/site_instance.h"
19 #include "content/public/browser/web_contents.h" 20 #include "content/public/browser/web_contents.h"
20 #include "extensions/browser/extensions_browser_client.h" 21 #include "extensions/browser/extensions_browser_client.h"
21 #include "extensions/common/extension.h" 22 #include "extensions/common/extension.h"
22 23
23 namespace { 24 namespace {
24 25
25 // Create a key that identifies a AppWindow in a RenderViewHost across App 26 // Create a key that identifies a AppWindow in a RenderViewHost across App
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void AppWindowRegistry::Observer::OnAppWindowShown(AppWindow* app_window) { 65 void AppWindowRegistry::Observer::OnAppWindowShown(AppWindow* app_window) {
65 } 66 }
66 67
67 AppWindowRegistry::Observer::~Observer() { 68 AppWindowRegistry::Observer::~Observer() {
68 } 69 }
69 70
70 AppWindowRegistry::AppWindowRegistry(content::BrowserContext* context) 71 AppWindowRegistry::AppWindowRegistry(content::BrowserContext* context)
71 : context_(context), 72 : context_(context),
72 devtools_callback_(base::Bind(&AppWindowRegistry::OnDevToolsStateChanged, 73 devtools_callback_(base::Bind(&AppWindowRegistry::OnDevToolsStateChanged,
73 base::Unretained(this))) { 74 base::Unretained(this))) {
74 content::DevToolsAgentHost::AddAgentStateCallback(devtools_callback_); 75 content::DevToolsManager::GetInstance()->AddAgentStateCallback(
76 devtools_callback_);
75 } 77 }
76 78
77 AppWindowRegistry::~AppWindowRegistry() { 79 AppWindowRegistry::~AppWindowRegistry() {
78 content::DevToolsAgentHost::RemoveAgentStateCallback(devtools_callback_); 80 content::DevToolsManager::GetInstance()->RemoveAgentStateCallback(
81 devtools_callback_);
79 } 82 }
80 83
81 // static 84 // static
82 AppWindowRegistry* AppWindowRegistry::Get(content::BrowserContext* context) { 85 AppWindowRegistry* AppWindowRegistry::Get(content::BrowserContext* context) {
83 return Factory::GetForBrowserContext(context, true /* create */); 86 return Factory::GetForBrowserContext(context, true /* create */);
84 } 87 }
85 88
86 void AppWindowRegistry::AddAppWindow(AppWindow* app_window) { 89 void AppWindowRegistry::AddAppWindow(AppWindow* app_window) {
87 BringToFront(app_window); 90 BringToFront(app_window);
88 FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowAdded(app_window)); 91 FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowAdded(app_window));
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 return false; 347 return false;
345 } 348 }
346 349
347 content::BrowserContext* AppWindowRegistry::Factory::GetBrowserContextToUse( 350 content::BrowserContext* AppWindowRegistry::Factory::GetBrowserContextToUse(
348 content::BrowserContext* context) const { 351 content::BrowserContext* context) const {
349 return extensions::ExtensionsBrowserClient::Get()->GetOriginalContext( 352 return extensions::ExtensionsBrowserClient::Get()->GetOriginalContext(
350 context); 353 context);
351 } 354 }
352 355
353 } // namespace apps 356 } // namespace apps
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698