Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: Source/core/xml/XMLHttpRequest.h

Issue 467593002: Fix incorrect comment about XMLHttpRequest::handleDidCancel() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XMLHttpRequest.h
diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h
index 5b6abc437918101b27e896c7360ac00c805ce47c..ce6455905aecc1d1b8a294f06bbd6dab7d972a08 100644
--- a/Source/core/xml/XMLHttpRequest.h
+++ b/Source/core/xml/XMLHttpRequest.h
@@ -211,7 +211,14 @@ private:
void handleDidFailGeneric();
// Handles didFail() call not caused by cancellation or timeout.
void handleNetworkError();
- // Handles didFail() call triggered by m_loader->cancel().
+ // Handles didFail() call for cancellation.
sof 2014/08/12 12:24:00 "Handles didFail() call for error cancellations" ?
sof 2014/08/12 12:29:51 Hmm, scratch that - i think it is fine to leave ou
tyoshino (SeeGerritForStatus) 2014/08/12 12:34:46 not errors of/meaning cancellation or cancellation
sof 2014/08/12 12:42:56 The former covers it more closely, I think, but ho
tyoshino (SeeGerritForStatus) 2014/08/12 13:48:36 np. thanks for review. Using "cancellations".
+ //
+ // This is not for the abort() method of the XHR. abort() calls
sof 2014/08/12 12:24:00 Why mention the implementation mechanics of abort(
tyoshino (SeeGerritForStatus) 2014/08/12 12:34:46 Oh, I see. Removed!
+ // internalAbort() which sets m_error which prevents handleDidCancel() from
+ // being called. This method handles cancellation coming from other
+ // components. For example, the ResourceLoader handling the load notifies
+ // m_loader of cancellation when the frame containing the XHR navigates
+ // away.
void handleDidCancel();
// Handles didFail() call for timeout.
void handleDidTimeout();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698