Fix incorrect comment about XMLHttpRequest::handleDidCancel()

Fix incorrect comment about XMLHttpRequest::handleDidCancel()

handleDidCancel() doesn't handle m_loader->cancel() in internalAbort().
It's for handling cancellation coming from other components.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180078

[sof, 2014-08-12 12:24:00]

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:214: // Handles didFail() call for
cancellation.
"Handles didFail() call for error cancellations" ?

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:216: // This is not for the abort() method of
the XHR. abort() calls
Why mention the implementation mechanics of abort() here; isn't that covered by
the comment next to the m_error check in didFail() already?

[sof, 2014-08-12 12:29:52]

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:214: // Handles didFail() call for
cancellation.
On 2014/08/12 12:24:00, sof wrote:
> "Handles didFail() call for error cancellations" ?

Hmm, scratch that - i think it is fine to leave out that detail and keep it as
it is.

[tyoshino (SeeGerritForStatus), 2014-08-12 12:34:46]

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:214: // Handles didFail() call for
cancellation.
On 2014/08/12 12:24:00, sof wrote:
> "Handles didFail() call for error cancellations" ?

not
errors of/meaning cancellation
or
cancellation type error?

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:216: // This is not for the abort() method of
the XHR. abort() calls
On 2014/08/12 12:24:00, sof wrote:
> Why mention the implementation mechanics of abort() here; isn't that covered
by
> the comment next to the m_error check in didFail() already?

Oh, I see. Removed!

[sof, 2014-08-12 12:42:56]

lgtm

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:214: // Handles didFail() call for
cancellation.
On 2014/08/12 12:34:46, tyoshino wrote:
> On 2014/08/12 12:24:00, sof wrote:
> > "Handles didFail() call for error cancellations" ?
> 
> not
> errors of/meaning cancellation
> or
> cancellation type error?

The former covers it more closely, I think, but how cancellation is signalled to
didFail() isn't that important to know here.

Fine as you had it; sorry about the noise.

[tyoshino (SeeGerritForStatus), 2014-08-12 13:48:37]

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
File Source/core/xml/XMLHttpRequest.h (right):

https://codereview.chromium.org/467593002/diff/1/Source/core/xml/XMLHttpReque...
Source/core/xml/XMLHttpRequest.h:214: // Handles didFail() call for
cancellation.
On 2014/08/12 12:42:56, sof wrote:
> On 2014/08/12 12:34:46, tyoshino wrote:
> > On 2014/08/12 12:24:00, sof wrote:
> > > "Handles didFail() call for error cancellations" ?
> > 
> > not
> > errors of/meaning cancellation
> > or
> > cancellation type error?
> 
> The former covers it more closely, I think, but how cancellation is signalled
to
> didFail() isn't that important to know here.
> 
> Fine as you had it; sorry about the noise.

np. thanks for review. Using "cancellations".

[tyoshino (SeeGerritForStatus), 2014-08-12 13:48:39]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-08-12 13:49:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/467593002/40001

[commit-bot: I haz the power, 2014-08-12 14:49:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19478)

[commit-bot: I haz the power, 2014-08-12 15:42:50]

Change committed as 180078