Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 467573002: Cleanup namespace usage in Source/web/Web*.h (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, caseq+blink_chromium.org, philipj_slow, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, feature-media-reviews_chromium.org, eric.carlson_apple.com, tzik, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, nhiroki, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, dcheng, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in Source/web/Web*.h This patch removes unnecessary blink:: prefixes. Also it merges *namespace blink{}* blocks. Also correcting blink presubmit errors in the changed files. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -303 lines) Patch
M Source/web/WebDataSourceImpl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 8 chunks +12 lines, -15 lines 0 comments Download
M Source/web/WebDevToolsAgentPrivate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFontImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebHelperPluginImpl.h View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/web/WebInputEventConversion.h View 1 chunk +31 lines, -34 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 10 chunks +26 lines, -28 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 4 chunks +17 lines, -20 lines 0 comments Download
M Source/web/WebPagePopupImpl.h View 4 chunks +11 lines, -14 lines 0 comments Download
M Source/web/WebPageSerializerImpl.h View 4 chunks +13 lines, -15 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 7 chunks +35 lines, -37 lines 0 comments Download
M Source/web/WebPluginScrollbarImpl.h View 4 chunks +8 lines, -11 lines 0 comments Download
M Source/web/WebPopupMenuImpl.h View 5 chunks +12 lines, -15 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 2 chunks +7 lines, -9 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSocketChannelClientProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSocketImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebTextCheckingCompletionImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 19 chunks +59 lines, -60 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-12 10:42:51 UTC) #1
tkent
lgtm
6 years, 4 months ago (2014-08-12 14:01:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/467573002/1
6 years, 4 months ago (2014-08-12 14:02:21 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 14:54:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 15:34:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22295)
6 years, 4 months ago (2014-08-12 15:34:33 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-12 15:43:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/467573002/1
6 years, 4 months ago (2014-08-12 15:44:04 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 16:22:48 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 16:53:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22312)
6 years, 4 months ago (2014-08-12 16:53:30 UTC) #11
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-12 23:32:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/467573002/1
6 years, 4 months ago (2014-08-12 23:33:51 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 00:48:54 UTC) #14
Message was sent while issue was closed. 
Change committed as 180126

Powered by Google App Engine
This is Rietveld 408576698