Issue 467563002: Refactor dmprof: remove no_dump flag for 'buckets' in load_basic_files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467563002: Refactor dmprof: remove no_dump flag for 'buckets' in load_basic_files. (Closed)

Created:
6 years, 4 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
6 years, 4 months ago

Reviewers:
hajimehoshi

CC:
chromium-reviews, dmikurube+memory_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Refactor dmprof: remove no_dump flag for 'buckets' in load_basic_files. It's the third step to accept Android's heap profiler discussed in http://crbug.com/382489. BUG=391212 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289255

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
	M	tools/deep_memory_profiler/lib/subcommand.py	View		3 chunks	+6 lines, -10 lines	0 comments	Download
	M	tools/deep_memory_profiler/subcommands/buckets.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Dai Mikurube (NOT FULLTIME)

Hi, Could you take a look when you have time? The plan to directly import ...

6 years, 4 months ago (2014-08-13 05:02:02 UTC) #1

Dai Mikurube (NOT FULLTIME)

The CQ bit was checked by dmikurube@chromium.org

6 years, 4 months ago (2014-08-13 05:17:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/467563002/20001

6 years, 4 months ago (2014-08-13 05:18:28 UTC) #5

Message was sent while issue was closed.

Change committed as 289255