Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 467533002: Aligned srcset mixedContent blocking to the spec (Closed)

Created:
6 years, 4 months ago by Yoav Weiss
Modified:
6 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Aligned srcset mixedContent blocking to the spec Previous implementation did not block mixed content when the srcset attribute was empty. This CL fixes that. BUG=402792 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180059

Patch Set 1 #

Patch Set 2 : Added a separate test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
A + LayoutTests/http/tests/security/mixedContent/insecure-empty-srcset-in-main-frame-blocked.html View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/security/mixedContent/insecure-empty-srcset-in-main-frame-blocked-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoav Weiss
6 years, 4 months ago (2014-08-12 07:59:53 UTC) #1
Mike West
On 2014/08/12 07:59:53, Yoav Weiss wrote: LGTM if you add a test that checks this ...
6 years, 4 months ago (2014-08-12 08:05:05 UTC) #2
Yoav Weiss
On 2014/08/12 08:05:05, Mike West wrote: > On 2014/08/12 07:59:53, Yoav Weiss wrote: > > ...
6 years, 4 months ago (2014-08-12 08:14:33 UTC) #3
Mike West
SLGTM, thanks!
6 years, 4 months ago (2014-08-12 08:15:53 UTC) #4
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-08-12 08:15:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/467533002/20001
6 years, 4 months ago (2014-08-12 08:17:01 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 09:24:34 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 10:34:24 UTC) #8
Message was sent while issue was closed.
Change committed as 180059

Powered by Google App Engine
This is Rietveld 408576698