Issue 467503002: Move DOMSelection.[cpp/h] from core/page to core/editing

Issue 467503002: Move DOMSelection.[cpp/h] from core/page to core/editing (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu

Modified:
6 years, 4 months ago

Reviewers:
yosin_UTC9, Yuta Kitamura, Inactive

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Move DOMSelection.[cpp/h] from core/page to core/editing Since this file is associated with the Editing module, this should be kept in core/editing instead of core/page. BUG=402417 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180055

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -791 lines)			Patch
M	Source/core/core.gypi	View		4 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/TreeScope.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download
A +	Source/core/editing/DOMSelection.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
A +	Source/core/editing/DOMSelection.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/core/editing/Selection.idl	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	Source/core/page/DOMSelection.h	View		1 chunk	+0 lines, -121 lines	0 comments	Download
D	Source/core/page/DOMSelection.cpp	View		1 chunk	+0 lines, -568 lines	0 comments	Download
D	Source/core/page/Selection.idl	View		1 chunk	+0 lines, -96 lines	0 comments	Download

Total messages: 6 (0 generated)

yosin_UTC9

LGTM Thanks for cleaning up! +yutak@ for OWNERS review.

6 years, 4 months ago (2014-08-12 05:54:19 UTC) #2

Yuta Kitamura

LGTM Yeah, I think this stuff should really live in editing/, instead of page/.

6 years, 4 months ago (2014-08-12 08:57:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/467503002/20001

6 years, 4 months ago (2014-08-12 08:58:31 UTC) #5

Message was sent while issue was closed.

Change committed as 180055